Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLE: Update cordio porting guide #6742

Merged
merged 2 commits into from May 8, 2018
Merged

BLE: Update cordio porting guide #6742

merged 2 commits into from May 8, 2018

Conversation

pan-
Copy link
Member

@pan- pan- commented Apr 25, 2018

Description

Remove a section of the cordio porting guide as it is not applicable anymore.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@pan-
BLE: Update cordio porting guide
6bb8031 
Remove the section "Include prebuilt libraries" as it is not applicable
anymore.
@pan- pan- requested a review from donatieng April 25, 2018 10:50
@pan-
BLE: Remove example section from cordio porting guide.
2c8b9ab 
This section is not applicable in the public version of mbed-os.
donatieng
donatieng reviewed Apr 25, 2018
View reviewed changes
features/FEATURE_BLE/targets/TARGET_CORDIO/doc/PortingGuide.md
achieved by adding the string `CORDIO` in the list of the `extra_labels`
property of the target.

```json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is still required? (except for WSHCI, WSSEC)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit was redundant; please look at the section above: Include Cordio BLE implementation.

@0xc0170
Copy link
Contributor

0xc0170 commented May 3, 2018

@donatieng Is this ready to go or not? Please leave the feedback

donatieng
donatieng approved these changes May 4, 2018
View reviewed changes
Copy link
Contributor

@donatieng donatieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comment @pan-, it's redundant indeed :)

@cmonr
Copy link
Contributor

cmonr commented May 7, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 7, 2018

Build : SUCCESS

Build number : 1937
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6742/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 8, 2018

Exporter Build : SUCCESS

Build number : 1583
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6742/

@mbed-ci
Copy link

mbed-ci commented May 8, 2018

Test : SUCCESS

Build number : 1759
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6742/1759

@cmonr cmonr merged commit adcd7ec into ARMmbed:master May 8, 2018
@pan- pan- deleted the ble-update-cordio-porting-guide branch November 14, 2018 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@donatieng donatieng donatieng approved these changes

Assignees
No one assigned
Labels
release-version: 5.8.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pan- @0xc0170 @cmonr @mbed-ci @donatieng @adbridge