New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: Update cordio porting guide #6742

Merged
merged 2 commits into from May 8, 2018

Conversation

Projects
None yet
6 participants
@pan-
Member

pan- commented Apr 25, 2018

Description

Remove a section of the cordio porting guide as it is not applicable anymore.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
BLE: Update cordio porting guide
Remove the section "Include prebuilt libraries" as it is not applicable
anymore.

@pan- pan- requested a review from donatieng Apr 25, 2018

BLE: Remove example section from cordio porting guide.
This section is not applicable in the public version of mbed-os.
achieved by adding the string `CORDIO` in the list of the `extra_labels`
property of the target.

```json

This comment has been minimized.

@donatieng

donatieng Apr 25, 2018

Member

I guess this is still required? (except for WSHCI, WSSEC)

This comment has been minimized.

@pan-

pan- Apr 27, 2018

Member

This bit was redundant; please look at the section above: Include Cordio BLE implementation.

@adbridge adbridge added needs: work and removed needs: review labels Apr 30, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 3, 2018

@donatieng Is this ready to go or not? Please leave the feedback

@donatieng

Thanks for addressing my comment @pan-, it's redundant indeed :)

@0xc0170 0xc0170 added needs: CI and removed needs: work labels May 7, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 7, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 7, 2018

Build : SUCCESS

Build number : 1937
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6742/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 8, 2018

@cmonr cmonr merged commit adcd7ec into ARMmbed:master May 8, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9025 cycles (-1159 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10112B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label May 8, 2018

@pan- pan- deleted the pan-:ble-update-cordio-porting-guide branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment