New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: Conditional compilation of H4 driver #6743

Merged
merged 2 commits into from May 8, 2018

Conversation

Projects
None yet
5 participants
@pan-
Member

pan- commented Apr 25, 2018

Description

The H4 driver requires UART to exposes flow control; this patch prevents symbol definition and compilation of the driver if DEVICE_SERIAL_FC is not defined by the target.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@pan- pan- requested a review from donatieng Apr 25, 2018

@0xc0170 0xc0170 changed the title from BLE: Conditionnal compilation of H4 driver to BLE: Conditional compilation of H4 driver Apr 25, 2018

@donatieng

LGTM - could we removePortingGuide.md from the PR though?

@pan-

This comment has been minimized.

Member

pan- commented Apr 25, 2018

I've made 6eae518 so that it's clearly indicated in the porting guide that the H4 driver is reserved to targets supporting flow control. However I do agree that it would have been better to put 0bb22cd in its own PR.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 26, 2018

However I do agree that it would have been better to put 0bb22cd in its own PR.

Can you please? We will tag docs team to review that change and the rest will become simple changes

@0xc0170 0xc0170 added needs: work and removed needs: review labels Apr 26, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 3, 2018

@pan- What is the status of this PR? How can we proceed?

pan- added some commits Apr 25, 2018

BLE: update cordio porting guide.
Improve description of the requirements of the H4 driver.
Cordio: Improve cordio H4 driver.
Ommit H4 driver definition if serial flow control is not supported.

@pan- pan- force-pushed the pan-:ble-cordio-h4-conditionnal-to-fc branch from d889a74 to 5659216 May 4, 2018

@pan-

This comment has been minimized.

Member

pan- commented May 4, 2018

@0xc0170 PR updated.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels May 7, 2018

@0xc0170

0xc0170 approved these changes May 7, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 7, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 7, 2018

Build : SUCCESS

Build number : 1936
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6743/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 5b5c8dd into ARMmbed:master May 8, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 582 warnings (+0 warnings)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10209 cycles (+1302 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label May 8, 2018

@pan- pan- deleted the pan-:ble-cordio-h4-conditionnal-to-fc branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment