New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify mesh configuration values. #6745

Merged
merged 1 commit into from Apr 27, 2018

Conversation

Projects
None yet
5 participants
@SeppoTakalo
Contributor

SeppoTakalo commented Apr 25, 2018

Description

A number of the configuration values in the mbed_lib.json files for Mesh contain 'help' fields which were missing acceptable ranges for their associated values.
This PR adds the missing ranges.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Clarify mesh configuration values.
Most of the help fields were correct. Just add field specifying
acceptable ranges.

@0xc0170 0xc0170 added the needs: CI label Apr 25, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 25, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 25, 2018

Build : SUCCESS

Build number : 1854
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6745/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 26, 2018

@SeppoTakalo With future PRs, please be sure to indicate the type of PR is being submitted. This PR has been modified as an example.

@cmonr cmonr merged commit a19a528 into ARMmbed:master Apr 27, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9533 cycles (-671 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10112B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 27, 2018

@SeppoTakalo SeppoTakalo deleted the SeppoTakalo:mesh_docs branch Apr 27, 2018

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Apr 27, 2018

@cmonr Thanks for notifying. I removed the template completely because there were nothing related to documentation. But as this is correction of the documentation the [ x ] Fix is the correct category.

@adbridge

This comment has been minimized.

Contributor

adbridge commented Apr 27, 2018

@SeppoTakalo The template should be left as is and a Description added where stated along with the PR type, otherwise the automated scripts that will soon run against all PRs will fail...In fact it explicitly gives this advice in the PR template itself.....
I've also updated the description itself to make it clear the level of detail we will be expecting here going forward.

@mbed-ci

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment