New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoRaWAN: Memory corruption due to band mishandling #6750

Merged
merged 1 commit into from Apr 30, 2018

Conversation

Projects
None yet
8 participants
@hasnainvirk
Contributor

hasnainvirk commented Apr 26, 2018

Description

band_t structure in phy parameters was not being filled in properly
and we were spilling over the array boundary for bands.
In addition to that two utility functions are added to perform safety
checking taking in the frequency and filling out band information plus
boundary value checks.

Pull request type

[X ] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from AnttiKauppila Apr 26, 2018

@0xc0170 0xc0170 changed the title from Memory corruption fix to Lorawan: memory corruption fix Apr 26, 2018

LoRaWAN: Memory corruption due to band mishandling
band_t structure in phy parameters was not being filled in properly
and we were spilling over the array boundary for bands.
In addition to that two utility functions are added to perform safety
checking taking in the frequency and filling out band information plus
boundry value checks.

@hasnainvirk hasnainvirk force-pushed the hasnainvirk:mem_corruption_fix branch from 5c2d030 to a6a1cee Apr 26, 2018

@hasnainvirk hasnainvirk changed the title from Lorawan: memory corruption fix to LoRaWAN: Memory corruption due to band mishandling Apr 26, 2018

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Apr 26, 2018

@kivaisan @kjbracey-arm Can you please review ?

@0xc0170 0xc0170 requested review from kjbracey-arm and kivaisan Apr 26, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 26, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 26, 2018

Build : SUCCESS

Build number : 1861
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6750/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added needs: CI and removed needs: review labels Apr 27, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 27, 2018

Waiting for one final approval from requested reviewers

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 27, 2018

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Apr 30, 2018

@cmonr @0xc0170 Could this be merged ?

@cmonr cmonr merged commit 4ca512d into ARMmbed:master Apr 30, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10293 cycles (+89 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10112B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment