New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nano 100: Lower HEAP size for IAR #6768

Merged
merged 1 commit into from May 7, 2018

Conversation

Projects
None yet
6 participants
@deepikabhavnani
Contributor

deepikabhavnani commented Apr 27, 2018

Description

IAR 7.8 does not support dynamic heap, and some test/addition of new feature fail on this device because of less static RAM memory. Reducing the heap memory size for the same reason.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@ccli8 @ccchang12

Updating HEAP size
IAR 7.8 does not support dynamic heap, and some test/addition of new
feature fail on this device because of less static RAM memory.
Reducing the heap memory size for the same reason.
@0xc0170

0xc0170 approved these changes May 3, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 3, 2018

@ccli8 @ccchang12

Can you please review this change?

/morph build

@ccli8

This comment has been minimized.

Contributor

ccli8 commented May 3, 2018

@deepikabhavnani I send another PR #6799 to spare more memory for your addition of new feature. Per our experience, some Greentea/CI tests would fail due to insufficient heap.

@mbed-ci

This comment has been minimized.

mbed-ci commented May 3, 2018

Build : SUCCESS

Build number : 1896
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6768/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@ccli8

ccli8 approved these changes May 3, 2018

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented May 3, 2018

@ccli8 - We have some devices with 0x1000 heap size and 0x400 stack size and looks like we didn;t had any issue with CI with heap change. Is it fine to go ahead with this change?

@0xc0170 0xc0170 changed the title from Updating HEAP size to Nano 100: Lower HEAP size for IAR May 3, 2018

@ccli8

This comment has been minimized.

Contributor

ccli8 commented May 4, 2018

@deepikabhavnani OK. Go with 0x1000 heap size and 0x400 stack size.

@ccli8

This comment has been minimized.

Contributor

ccli8 commented May 4, 2018

@deepikabhavnani Correct above. Go with 0x1000 or 0x1200 heap size and 0x400 stack size only for IAR toolchain.

@cmonr cmonr merged commit 809f183 into ARMmbed:master May 7, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9815 cycles (-363 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10112B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label May 7, 2018

@deepikabhavnani deepikabhavnani deleted the deepikabhavnani:iar_nan0130 branch May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment