New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move subtract basepath into the resources class #6769

Merged
merged 1 commit into from May 7, 2018

Conversation

Projects
None yet
4 participants
@theotherjimmy
Contributor

theotherjimmy commented Apr 27, 2018

Description

A bug, #6755, was the result of the subtract_basepath function not
being applied to a resources object's children (it's features). This PR
fixes this bug by moving this functionality into the resources class.
Then, I applied the subtract_basepath method to the children resource
objects recursively. This has been tested on Partnerbeta and is to
upstream the fix.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Apr 27, 2018

It's even shorter now 😄

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Apr 27, 2018

@cmonr Could you review?

@yennster @chris-styles This is the fix to both of your bugs.

@adbridge adbridge requested a review from cmonr Apr 30, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 3, 2018

The changes looks good to me but

A bug, #6755, was the result of the subtract_basepath function not
being applied to a resources object's children (it's features). This PR
fixes this bug by moving this functionality into the resources class.
Then, I applied the subtract_basepath method to the children resource
objects recursively. This has been tested on Partnerbeta and is to
upstream the fix.

can you amend this to the commit message?

@0xc0170 0xc0170 added needs: work and removed needs: review labels May 3, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 3, 2018

@0xc0170 That'll be just a moment. I'll start testing after I do to keep things rolling.

Apply subtract basepath to features
A bug, #6755, was the result of the `subtract_basepath` function not
being applied to a resources object's children (it's features). This PR
fixes this bug by moving this functionality into the resources class.
Then, I applied the `subtract_basepath` method to the children resource
objects recursively. This has been tested on Partnerbeta and is to
upstream the fix.

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:fix-subtract-basepath branch from a7e7f8e to d338e67 May 3, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 3, 2018

@0xc0170 Added entire description field to the commit message.

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 3, 2018

Build : SUCCESS

Build number : 1907
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6769/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@0xc0170 0xc0170 added needs: review and removed needs: work labels May 3, 2018

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

0xc0170 approved these changes May 4, 2018

@cmonr

cmonr approved these changes May 7, 2018

@cmonr cmonr merged commit 2ddce27 into ARMmbed:master May 7, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 582 warnings
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10259 cycles (+59 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10112B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment