New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAX32625PICO] Add new platform #6779

Merged
merged 3 commits into from May 11, 2018

Conversation

Projects
None yet
6 participants
@khariya
Contributor

khariya commented Apr 30, 2018

Depends on PR #6778

Description

MAX32625PICO is available with and without Bootloader.
Use target name MAX32625PICO_NO_BOOT to compile without the bootloader.
Use target name MAX32625PICO to compile with the bootloader.

Test results:
mbed_test_max32625pico-no-boot_arm.txt
mbed_test_max32625pico-no-boot_gcc-arm.txt
mbed_test_max32625pico-no-boot_iar.txt

Tested all supported toolchains with MAX32625PICO

Pull request type

[ ] Fix
[ ] Refactor
[X] New target
[ ] Feature
[ ] Breaking change
@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 2, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 2, 2018

Build : SUCCESS

Build number : 1889
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6779/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 3, 2018

/morph mbed2-build
/morph test

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 3, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 3, 2018

/morph test

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 3, 2018

@khariya Please resolve the conflict

@0xc0170 0xc0170 added needs: work and removed needs: CI labels May 3, 2018

khariya added some commits Apr 30, 2018

[MAX32625PICO] Add new platform
This platform is available with or without Bootloader.

@khariya khariya force-pushed the maximmbed:add-max32625pico branch from adadb04 to 04ae15a May 3, 2018

@khariya

This comment has been minimized.

Contributor

khariya commented May 3, 2018

Conflict resolved. Rebased with the master branch.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels May 4, 2018

@cmonr cmonr requested a review from ashok-rao May 7, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 7, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 7, 2018

Build : SUCCESS

Build number : 1933
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6779/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented May 7, 2018

@khariya , for the target with the bootloader, are there any post build steps required to "combine" the bootloader with the generated binary?

SPI2_MOSI = P2_5,
SPI2_MISO = P2_6,
SPI2_SS = P2_7,

This comment has been minimized.

@ashok-rao

ashok-rao May 7, 2018

Contributor

@khariya : Since there are multiple peripherals of each type, it would be recommended to define a "default" for each one.. for ex: SPI_MOSI = SPI1_MOSI , I2C_SDA = I2C1_SDA & so on.. so that application code doesn't need to explicitly specify the peripheral number to use..

This comment has been minimized.

@khariya

khariya May 7, 2018

Contributor

@ashok-rao Added the default defines. Thanks.

@khariya

This comment has been minimized.

Contributor

khariya commented May 7, 2018

@ashok-rao No additional post-build steps are required for the target with the bootloader, the generated binary is sufficient.
Please note that the bootloader must be programmed separately before dropping the application binary. Compiling the target with bootloader does not combine the bootloader with the application.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 8, 2018

Restarting CI. The last commit looks fine.

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 8, 2018

Build : SUCCESS

Build number : 1942
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6779/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented May 8, 2018

Thanks @khariya for adding the defaults. Regarding bootloader, curious to know how this will be made available to end users? Will there be a link somewhere on the platform page?

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 8, 2018

/morph mbed2-build

1 similar comment
@cmonr

This comment has been minimized.

Contributor

cmonr commented May 8, 2018

/morph mbed2-build

@khariya

This comment has been minimized.

Contributor

khariya commented May 8, 2018

@ashok-rao The MAX32625PICO board(as a target, not as a programmer) comes with the bootloader installed on it by default.
Thanks.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 9, 2018

/morph mbed2-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 9, 2018

@ashok-rao Does this link answer your question? https://os.mbed.com/platforms/MAX32625PICO/#default-daplink-image

@khariya Is it expected that this link will be updated when updates are needed/available?

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented May 10, 2018

Thanks for the link @cmonr . All other changes good to go from my side.
@khariya : can we have the default bootloader binary provided to users from that link as well? or steps/ link to update it when there are updates to it in the future.. along with DAPlink as already provided.. thanks.

@ashok-rao

LGTM! Thanks @khariya

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 10, 2018

@khariya I'm ready to give the ok and get this merged in once we get the last couple of questions answered.

@cmonr cmonr added the needs: review label May 10, 2018

@khariya

This comment has been minimized.

Contributor

khariya commented May 10, 2018

@cmonr @ashok-rao The platform page will be updated when needed.
We can provide the default bootloader binary on the platform page along with instructions. Additional hardware will be required to update the bootloader.

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented May 10, 2018

thanks @khariya . Please update the instructions on the platform page along with any specific HW / SW requirements. Thanks.

@khariya

This comment has been minimized.

Contributor

khariya commented May 10, 2018

Yes, I will update the platform page. Thanks!

@cmonr

cmonr approved these changes May 10, 2018

@cmonr cmonr merged commit 4318caa into ARMmbed:master May 11, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 845 warnings (+0 warnings)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9625 cycles (+841 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label May 11, 2018

@khariya khariya deleted the maximmbed:add-max32625pico branch May 11, 2018

@adbridge

This comment has been minimized.

Contributor

adbridge commented May 18, 2018

There is something very strange in the commit history for this PR. Trying to cherry pick across to 5.8 we get the following:

error: patch failed: targets/TARGET_Maxim/TARGET_MAX32625/device/TOOLCHAIN_IAR/TARGET_MAX32625MBED/MAX32625.icf:1
error: targets/TARGET_Maxim/TARGET_MAX32625/device/TOOLCHAIN_IAR/TARGET_MAX32625MBED/MAX32625.icf: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.

As I can't see an easy way of fixing this I'm going to push it out to 5.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment