New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Add dynamic alloc and destruction to easycellular #6792

Merged
merged 1 commit into from May 7, 2018

Conversation

Projects
None yet
5 participants
@jarvte
Contributor

jarvte commented May 2, 2018

Description

Added dynamic alloc and destruction to easycellular.
Now application can call connect and disconnect multiple times and resources are freed and constructed properly. Also whole easycellular can be deleted and constructed again.

Internal ref to defect: IOTCELL-814

@AriParkkila please review

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from AriParkkila May 2, 2018

@0xc0170 0xc0170 changed the title from Cellular: Added dynamic alloc and destruction to easycellular. to Cellular: Add dynamic alloc and destruction to easycellular May 3, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 3, 2018

The commit does not specify why this is being added? Is it really a fix - what does it fix?

After checking, IOTCELL-814, its more clear - thus this should be captured in the commit.

@0xc0170

Extend the commit message what is this fixing and how (looking at the changes, I am not certain this is a fix or introducing a new feature to the implementation)

@jarvte

This comment has been minimized.

Contributor

jarvte commented May 3, 2018

@0xc0170 updated commit message. This goes to 5.9 so fix/feature are both fine by me.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 3, 2018

@0xc0170 updated commit message. This goes to 5.9 so fix/feature are both fine by me.

Please push it to the branch, don't see it yet.

Add instead of Added (see our guidelines in the handbook for the commit messages)

Cellular: Added dynamic alloc and destruction to easycellular.
Now application can call connect and disconnect multiple times and resources are freed and constructed properly.
Also whole easycellular can be deleted and constructed again.

@jarvte jarvte force-pushed the jarvte:cellular_dynamic_alloc_and_destr branch from 1ae82ae to b22a16f May 3, 2018

@jarvte

This comment has been minimized.

Contributor

jarvte commented May 3, 2018

@0xc0170 sorry, updated PR description only, now also commit message...

@0xc0170

0xc0170 approved these changes May 3, 2018

@@ -153,7 +150,20 @@ FileHandle *ATHandler::get_file_handle()
void ATHandler::set_file_handle(FileHandle *fh)
{
_fh_sigio_set = false;

This comment has been minimized.

@AriParkkila

AriParkkila May 4, 2018

Contributor

If _fileHandle already has sigio set that should be removed?

This comment has been minimized.

@AriParkkila

AriParkkila May 4, 2018

Contributor

Answering my own question above. We have internal ticket IOTCELL-846 for that. This PR looks good.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 4, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 4, 2018

We will start CI once one important fix completes (master is affected).

@jarvte

This comment has been minimized.

Contributor

jarvte commented May 7, 2018

@0xc0170 fix done? Could morph be started?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 7, 2018

yes, starting now

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 7, 2018

Build : SUCCESS

Build number : 1924
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6792/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 7, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 7, 2018

@cmonr cmonr merged commit 7a1ab18 into ARMmbed:master May 7, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 582 warnings (+0 warnings)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8963 cycles (-1237 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10112B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label May 7, 2018

@jarvte jarvte deleted the jarvte:cellular_dynamic_alloc_and_destr branch May 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment