New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Pass app-config to get_config #6793

Merged
merged 2 commits into from May 7, 2018

Conversation

Projects
None yet
4 participants
@theotherjimmy
Contributor

theotherjimmy commented May 2, 2018

Description

The mbed test subcommand will run a quick get_config before building.
This get_config call was missing the --app-config parameter, because
get_config did not accept the --app-config parameter. This is resolved.

This has a side affect of fixing a bug with --app-config handling in
mbed test: Required parameters that are filled in by the --app-conifg
do not fail the build anymore.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Pass app config to get config
This corrects a bug which would manifest as --app-config not having
much of an affect on test builds (not the first libary bulid)
@0xc0170

0xc0170 approved these changes May 3, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 3, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 3, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented May 3, 2018

Build : SUCCESS

Build number : 1902
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6793/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 4, 2018

@cmonr cmonr merged commit c52a8d6 into ARMmbed:master May 7, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 582 warnings (+0 warnings)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10406 cycles (+367 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10112B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment