New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error with DirectSerial in serial-less build #6797

Merged
merged 1 commit into from May 7, 2018

Conversation

Projects
None yet
5 participants
@ccli8
Contributor

ccli8 commented May 3, 2018

Description

This PR tries to fix compile error with DirectSerial in serial-less build. My mbed_app.json has the following content for this build:

{
    "target_overrides": {
        "*": {
            "platform.stdio-baud-rate": 9600,
            "platform.stdio-convert-newlines": true
        },
        
        "NUMAKER_PFM_M2351_S": {
            "target.device_has_remove": ["SERIAL", "SERIAL_ASYNCH", "SERIAL_FC", "STDIO_MESSAGES"]
        
        }
    }
}

Related PR

#6747

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from kjbracey-arm May 3, 2018

@kjbracey-arm

Thanks! Surprised we'd not run into that sooner.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 3, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 3, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented May 3, 2018

Build : SUCCESS

Build number : 1898
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6797/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 4, 2018

@cmonr cmonr merged commit 39fd120 into ARMmbed:master May 7, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 582 warnings (+0 warnings)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8989 cycles (-1050 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10112B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label May 7, 2018

@ccli8 ccli8 deleted the OpenNuvoton:nuvoton_fix_noserial branch Jul 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment