New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Reorder test configuration priority #6805

Merged
merged 1 commit into from May 8, 2018

Conversation

Projects
None yet
4 participants
@theotherjimmy
Contributor

theotherjimmy commented May 3, 2018

Description

The mbed test subcommand Takes two arguments, --app-config and
--test-config. The test config parameter takes priority over the
app config parameter. Where things get weird is after that:
The current order (before this PR):

  • --test-config
  • --app-config
  • test config (as defined in test_config)
  • mbed_app.json in root.

That's probably because we did not have a good way to do what this PR
does:

  • --test-config
  • --app-config
  • mbed_app.json in root.
  • test config (as defined in test_config):

This gives the user more control and matches the documented behavior in
the arguments

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Reorder test configs
Old order:
 * --test-config
 * --app-config
 * test config (as defined in test_config)
 * `mbed_app.json` in root.

New order:
 * --test-config
 * --app-config
 * `mbed_app.json` in root.
 * test config (as defined in test_config)~

This matches the documentation and user expectation

@0xc0170 0xc0170 changed the title from tools: Reorder test configuration proirity to tools: Reorder test configuration priority May 4, 2018

@0xc0170

0xc0170 approved these changes May 4, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 4, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 7, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 7, 2018

Build : SUCCESS

Build number : 1931
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6805/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit ceeedfd into ARMmbed:master May 8, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 582 warnings (+0 warnings)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9963 cycles (-237 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10112B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label May 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment