New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System stats - API addition #6821

Merged
merged 3 commits into from May 21, 2018

Conversation

Projects
None yet
7 participants
@deepikabhavnani
Contributor

deepikabhavnani commented May 4, 2018

Description

System Stats Addition. Dependent on previous PR's. (Commits valid post ec71e46)

Status : Work in progress Done

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change

@deepikabhavnani deepikabhavnani changed the title from System stats to System stats - API addition May 4, 2018

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:system_stats branch 2 times, most recently from 930274b to 4209608 May 4, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 7, 2018

@deepikabhavnani Is this blocked on #508?

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented May 7, 2018

@cmonr - This is not dependent on "Thread/System API addition #508" which is on Handbook. But should be merged post #6795

@deepikabhavnani deepikabhavnani requested a review from SenRamakri May 8, 2018

@deepikabhavnani deepikabhavnani referenced this pull request May 9, 2018

Merged

CPU Statistics #6857

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:system_stats branch 3 times, most recently from 2e3a0d7 to f4395bc May 9, 2018

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented May 11, 2018

Rebased on top of master.. No PR dependency now.

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented May 11, 2018

@SenRamakri - Please review

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 14, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: work labels May 14, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented May 14, 2018

Build : SUCCESS

Build number : 1998
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6821/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented May 14, 2018

@0xc0170 - Command used in build does not contain ALL flags enabled. Will have to re-run once @studavekar does that change.

@studavekar

This comment has been minimized.

Collaborator

studavekar commented May 14, 2018

@0xc0170 - Command used in build does not contain ALL flags enabled. Will have to re-run once @studavekar does that change.

We should be good to run trigger the build on this PR, Logs from one of the PR

https://mbed-os.s3-eu-west-1.amazonaws.com/builds/6832/PASS/DISCO_F303VC/GCC_ARM/6154fd259845423b63fd8cc6a06f4798f3dd115e_build_log_DISCO_F303VC_GCC_ARM.txt

new command line looks like mbed test --compile -m <target> -t <toolchain> -DMBED_HEAP_STATS_ENABLED=1 -DMBED_STACK_STATS_ENABLED=1 -DMBED_TRAP_ERRORS_ENABLED=1 -DMBED_ALL_STATS_ENABLED

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 14, 2018

/morph build

Rerunning to use new build parameters.

@mbed-ci

This comment has been minimized.

mbed-ci commented May 14, 2018

@bulislaw

One thing I would like to add to the stats is the Mbed OS version.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 15, 2018

mbed OS version +1

to consider to be having in system stats if we have there mbed OS version - #6897 - having sha available or dirty flag, this might not be related to this one?

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented May 15, 2018

@bulislaw Will add Mbed OS version.

@0xc0170 - I am not sure if we can add SHA, but can look upon that in future.

deepikabhavnani added some commits May 3, 2018

System Info API addition
API added to get the system information like CPU ID, compiler ID and
compiler version.

@deepikabhavnani deepikabhavnani dismissed stale reviews from bulislaw, 0xc0170, and SenRamakri via 8f5cfd0 May 15, 2018

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:system_stats branch from f4395bc to 8f5cfd0 May 15, 2018

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented May 15, 2018

Rebased, added Mbed OS version and resolved Cortex-A compilation issue.

OS version added + CPUID for cortex-M only
CPUID base register is available for Cortex-M processors only.
Cortex-A devices have Main ID Register, which can be used in future to
get processor info.

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:system_stats branch from 8f5cfd0 to 1961428 May 15, 2018

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented May 16, 2018

Testing build to confirm Cortex-A issues resolved.

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 16, 2018

Build : SUCCESS

Build number : 2037
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6821/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 17, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 18, 2018

@0xc0170 @SenRamakri @bulislaw Are y'all alright with the updated changes?

@cmonr cmonr merged commit 97b1615 into ARMmbed:master May 21, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 845 warnings
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9575 cycles (+613 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label May 21, 2018

@deepikabhavnani deepikabhavnani deleted the deepikabhavnani:system_stats branch May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment