New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Remove long-deprecated build_everything.py #6823

Merged
merged 1 commit into from May 21, 2018

Conversation

Projects
None yet
5 participants
@theotherjimmy
Contributor

theotherjimmy commented May 4, 2018

Description

This needs to happen, because it removes a small disincentive to improving
the build system: verifying that this script still works. This PR removes
this file and the disincentive.

Pull request type

[ ] Fix
[x] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Remove build_everything.py
It's not used

@0xc0170 0xc0170 requested a review from screamerbg May 7, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 7, 2018

Is the reason that this file is long-deprecated because there are other tests that supercede it's functionality?

I took a look at its history, and found that the history is quite sparse. Is there any particular reason why other files that were a part of its original commit should not also be removed? (Ref: 0034ffb#diff-d1ccf7c14517be793178cf50b3203641)

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 8, 2018

@cmonr That commit is a big pile of unrelated features. It's long-deprecated because it does not have a call in travis, mbed-cli, or any other CI and it sees no maintenance.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 8, 2018

Starting a build to check something w/ the CI.
But also since this should be good but is still waiting on review.

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 8, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 8, 2018

Issues should be resolved.
/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 8, 2018

Build : SUCCESS

Build number : 1956
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6823/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented May 9, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

LGTM

@cmonr cmonr merged commit b165e9c into ARMmbed:master May 21, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 582 warnings
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9565 cycles (+658 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment