New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lora: Remove obsolete FEATURE_COMMON_PAL flags #6905

Merged
merged 1 commit into from May 21, 2018

Conversation

Projects
None yet
7 participants
@kivaisan
Contributor

kivaisan commented May 15, 2018

Description

mbed-trace no longer requires COMMON_PAL to be enabled.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change
@kivaisan

This comment has been minimized.

Contributor

kivaisan commented May 15, 2018

@kjbracey-arm @hasnainvirk please review

@kjbracey-arm

This comment has been minimized.

Contributor

kjbracey-arm commented May 15, 2018

Hmm, events testing and its "rm assorted bits of tree" strikes again. Add "lorawan" to its delete list?

@0xc0170 0xc0170 added the needs: work label May 15, 2018

@kjbracey-arm

This comment has been minimized.

Contributor

kjbracey-arm commented May 15, 2018

Add "lorawan" to its delete list?

Actually no, that'll just make the problem recur in future. You need to narrow down or eliminate its "frameworks" deletion.

@kivaisan

This comment has been minimized.

Contributor

kivaisan commented May 15, 2018

Including mbed_trace.h probably requires the path "mbed-trace". Adding it right now.

@kivaisan kivaisan dismissed stale reviews from 0xc0170 and kjbracey-arm via 2b8c563 May 15, 2018

@kivaisan kivaisan force-pushed the kivaisan:remove_common_pal_flags branch from 26a6326 to 2b8c563 May 15, 2018

@kivaisan

This comment has been minimized.

Contributor

kivaisan commented May 15, 2018

Hmm, events testing and its "rm assorted bits of tree" strikes again. Add "lorawan" to its delete list?

Let's see if deleting features/frameworks/greentea-client instead of whole frameworks is enough.

@kivaisan kivaisan force-pushed the kivaisan:remove_common_pal_flags branch from 2b8c563 to c2fd678 May 15, 2018

Lora: Remove obsolete FEATURE_COMMON_PAL flags
mbed-trace no longer requires COMMON_PAL to be enabled.

@kivaisan kivaisan force-pushed the kivaisan:remove_common_pal_flags branch from c2fd678 to 3094327 May 15, 2018

@kivaisan

This comment has been minimized.

Contributor

kivaisan commented May 16, 2018

Let's see if deleting features/frameworks/greentea-client instead of whole frameworks is enough.

Adding greentea-client, utest and unity seems to be enough and tests are passing now. @0xc0170 could you start morph tests now?

@0xc0170 0xc0170 added needs: CI and removed needs: work labels May 16, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 16, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 16, 2018

Build : SUCCESS

Build number : 2035
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6905/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

0xc0170 referenced this pull request May 16, 2018

Merge pull request #6577 from SeppoTakalo/remove_features
Get rid of FEATURE_COMMON_PAL and FEATURE_NANOSTACK
@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@kivaisan

This comment has been minimized.

Contributor

kivaisan commented May 17, 2018

@0xc0170 Could you check these latest test and exporter failures. Probably some CI problem as at least test failure seems to have some disk space problems?

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 17, 2018

/morph test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@kjbracey-arm

This comment has been minimized.

Contributor

kjbracey-arm commented May 18, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 19, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@adbridge adbridge added ready for merge and removed needs: CI labels May 21, 2018

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented May 21, 2018

@cmonr Could this go in now ?

@adbridge

This comment has been minimized.

Contributor

adbridge commented May 21, 2018

@hasnainvirk It will go in when we do gatekeeping at 4pm :)

@cmonr cmonr merged commit 16d3077 into ARMmbed:master May 21, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 845 warnings
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8582 cycles (-625 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment