New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: Quick name-fix for warnings reported by Astyle #6917

Merged
merged 1 commit into from May 18, 2018

Conversation

Projects
None yet
5 participants
@geky
Member

geky commented May 15, 2018

Description

Currently Astyle is reporting files with warnings, not the actual count of warnings. This is a bug, but fixing right now will cause incorrect results (and we're in the middle of preparing a release!). At least for the short-term we can change the name to avoid as much confusion as possible.

cc @0xc0170

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Travis: Quick name-fix for warnings reported by Astyle
Currently Astyle is reporting files with warnings, not the actual count
of warnings. This is a bug, but fixing right now will cause incorrect results.
At least for the short-term we can change the name to avoid as much confusion
as possible.
@0xc0170

Files 👍 much clearer now, even we got confused today about some +0 warnings reports when there were issues

@cmonr

cmonr approved these changes May 15, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 15, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 15, 2018

Build : SUCCESS

Build number : 2030
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6917/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 16, 2018

/morph test

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 16, 2018

Once the devices are fixed in CI, we will restart tests

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 17, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels May 17, 2018

@cmonr cmonr merged commit bb0c345 into master May 18, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
travis-ci/astyle Passed, 845 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8941 cycles (-21 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label May 18, 2018

@adbridge

This comment has been minimized.

Contributor

adbridge commented May 18, 2018

astyle is targeting 5.9, therefore so should this.

@geky geky deleted the g-astyle-rename-warnings branch May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment