New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Add explicit target for NVStore example #6919

Merged
merged 1 commit into from May 18, 2018

Conversation

Projects
None yet
5 participants
@cmonr
Contributor

cmonr commented May 15, 2018

Description

Realized with this PR (#6879) that nvstore was being compiled and tested against all targets. Limited example building for K64F, since example only calls out K64F.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@cmonr cmonr added the needs: review label May 15, 2018

@cmonr cmonr requested review from geky and davidsaada May 15, 2018

@cmonr cmonr changed the title from Added explicit target for NVStore to Added explicit target for NVStore example May 15, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 15, 2018

@davidsaada If there are other targets that are explicitly supported, please let us know (similar to this: b61912c).

@ARMmbed/mbed-os-maintainers This could also be why export tests have taken a bit longer, since this example is currently being built against all exported targets instead of a subset.

@davidsaada

Looks good to me.

@geky

geky approved these changes May 16, 2018

Looks good to me if David's happy

@0xc0170 0xc0170 changed the title from Added explicit target for NVStore example to tools: Add explicit target for NVStore example May 16, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 16, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 16, 2018

/morph build

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 17, 2018

Build was stuck trying to start on a node that was never brought online...

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 17, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 17, 2018

Build : SUCCESS

Build number : 2041
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6919/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 17, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 73eebae into ARMmbed:master May 18, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 845 warnings (+0 warnings)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9574 cycles (+612 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the needs: CI label May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment