New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Flash iAP and Bootloader for GR-PEACH and GR-LYCHEE #6925

Merged
merged 6 commits into from Jun 22, 2018

Conversation

Projects
None yet
9 participants
@TomoYamanaka
Contributor

TomoYamanaka commented May 16, 2018

Description

Renesas added flash iap and bootloader feature to GR-PEACH and GR-LYCHEE.

Flash iAP was successful by tests-mbed_drivers-flashiap and tests-mbed_hal-flash.
Also Those was tested with https://github.com/ARMmbed/mbed-os-example-bootloader and was successful.

Pull request type

[ ] Fix
[ ] Refactor
[x] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 18, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 20, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 20, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 20, 2018

@TomoYamanaka Please review the build failures

@0xc0170 0xc0170 added needs: work and removed needs: CI labels May 20, 2018

@TomoYamanaka TomoYamanaka force-pushed the TomoYamanaka:feature-flashiap_bootloader branch from 24c4324 to c809eda May 21, 2018

@TomoYamanaka

This comment has been minimized.

Contributor

TomoYamanaka commented May 21, 2018

I rebased my commits due to address the build failure.

@cmonr cmonr added needs: CI and removed needs: work labels May 21, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 21, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 21, 2018

Build : SUCCESS

Build number : 2086
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6925/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 22, 2018

Please review exporter failure. There are multiple warnings for redefinition (that would be nice to be fixed), but more importantly here - 3 failures reported for ARMCC

@TomoYamanaka

This comment has been minimized.

Contributor

TomoYamanaka commented May 23, 2018

Exporter occurs failure only IAR according the above report, so I modified the IAR definition for export.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels May 23, 2018

@TomoYamanaka

This comment has been minimized.

Contributor

TomoYamanaka commented May 24, 2018

With respect to the error message of Exporter for UVISION,

assembling irq_ca.S...
irq_ca.S: Error:  #5: cannot open source input file "__UVISION_VERSION SETA 521": No such file or directory
irq_ca.S: __UVISION_VERSION SETA 521: 0 warnings, 1 errorirq_ca.S: Error: A1067E: Output file specified as 'mbed-os\rtos\TARGET_CORTEX\rtx5\RTX\Source\TOOLCHAIN_ARM\TARGET_CORTEX_A\irq_ca.S', but it has already been specified as '.\build\irq_ca.o'
irq_ca.S: error: A1905U: Pre-processor step failed for '__UVISION_VERSION SETA 521'

I don' know why the message is outputed.
The specified file is out of this time's changes renge, and I cannot find "__UVISION_VERSION SETA 521" file into mbed-os repo.
mbed-os\rtos\TARGET_CORTEX\rtx5\RTX\Source\TOOLCHAIN_ARM\TARGET_CORTEX_A\irq_ca.S

Previously, although I updated this file for RTX5 update by cherry-picking from CMSIS_5 repo, I did not change it since then.
this error did not outputed in the PR of its updating.
#5628 (comment)

@toyowata Please help me to go ahead with the above.

@TomoYamanaka

This comment has been minimized.

Contributor

TomoYamanaka commented Jun 18, 2018

I will appreciate if you can accelerate the resolution because this is a blocker for Renesas user's activity.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 19, 2018

@TomoYamanaka It is high in my queue of work to get a PR in that will allow this to pass CI. Once that PR is made, I'll link it here.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 21, 2018

@TomoYamanaka #7295 has been created.

TomoYamanaka added some commits May 21, 2018

Support Flash iAP for GR-PEACH and GR-LYCHEE
The mainly changes is below:
- Add flash_api.c
- Add the definition of SPI multi I/O Bus controller that is used for flash access
- Add "FLASH" as device feature
- Add the macro regarding information of the incorporated Flash
- Add the processing to expand code to RAM
Support Bootloader for GR-PEACH and GR-LYCHEE
The mainly changes is below:
- Update scatter file, linker file for bootloader support
- Update the file for RZ/A1 serial flash boot loader
- Add "device name" and "bootloader_supported" in targets.json
Update arm pack manager for GR-LYCHEE
I added the information of GR-LYCHEE for supporting bootloader in index.json file of arm pack manager.
Add the process for Cortex-A in mbed_applicaion
I added the process for Cortex-A in mbed_application.c because this process was for only Cortex-M.
Also I enabled the macro of MBED_APPLICATION_SUPPORT for Cortex-A.
Update arm pack manager for GR-PEACH
I changed the information("sectors" and "memory") of GR-PEACH for supporting bootloader in index.json file of arm pack manager.

@TomoYamanaka TomoYamanaka dismissed stale reviews from theotherjimmy, 0xc0170, and cmonr via 72fd8ca Jun 22, 2018

@TomoYamanaka TomoYamanaka force-pushed the TomoYamanaka:feature-flashiap_bootloader branch from bff07fd to 72fd8ca Jun 22, 2018

@TomoYamanaka

This comment has been minimized.

Contributor

TomoYamanaka commented Jun 22, 2018

The exporter's problem was resolved, and I rebased to resolve a conflict of "tools/arm_pack_manager/index.json".
So could you review and re-trigger CI test again?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 22, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 22, 2018

Build : SUCCESS

Build number : 2432
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6925/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 8e170cc into ARMmbed:master Jun 22, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 919 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9098 cycles (+92 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 2, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 2, 2018

#ghostinthemachine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment