New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: AT debugging improved #6927

Merged
merged 3 commits into from May 24, 2018

Conversation

Projects
None yet
7 participants
@AriParkkila
Contributor

AriParkkila commented May 16, 2018

Description

  • Removed function entry debug prints
  • AT debug is less noisy and it now prints also written chars
  • AT debug can be enabled using "cellular.debug-at" flag
  • Cellular log now has atomic locks for tracing
  • Changed non-fatal error prints to less severe
  • Fixed cellular Greentea tests
  • ATHandler::read was fixed to handle zero length string ""
  • Renamed enable_debug to set_debug, that's API change but only for debugging
  • Removed obsolete FEATURE_COMMON_PAL flag from trace (CI fixed on #6905)

Pull request type

[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented May 16, 2018

@mirelachirica @jarvte please review

@0xc0170 0xc0170 requested review from jarvte and mirelachirica May 16, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 16, 2018

@AriParkkila Please review astyle travis info about changes (it shows diff of style issues in touched files).

@jarvte

jarvte approved these changes May 17, 2018

@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented May 22, 2018

Please proceed with this.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 22, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 22, 2018

/morph build

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 23, 2018

Odd. Not sure why a failure wasn't reported.

/morph build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 23, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 23, 2018

Build : SUCCESS

Build number : 2126
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6927/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 23, 2018

Shuffling around some jobs.

/morph export-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 23, 2018

/morph test

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 24, 2018

Performing another shuffle. Attempting to make sure #6993 is ready by the AM, if needed.

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 24, 2018

@AriParkkila Looks like this will need #6993 to pass. The test error is a newly discovered one that was found today.

That PR should be tested, merged, and ready to be rebased by the AM.

@mbed-ci

This comment has been minimized.

@kjbracey-arm

This comment has been minimized.

Contributor

kjbracey-arm commented May 24, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 24, 2018

Build : SUCCESS

Build number : 2137
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6927/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr removed the needs: CI label May 24, 2018

@cmonr cmonr merged commit 5ce26b1 into ARMmbed:master May 24, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 840 warnings (-5 warnings)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9900 cycles (+938 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment