New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOT_SUPPORTED error was not supported any more in test_api.py script #6939

Merged
merged 1 commit into from May 21, 2018

Conversation

Projects
None yet
5 participants
@jeromecoutant
Contributor

jeromecoutant commented May 17, 2018

Description

If OS2 test contains the NOT_SUPPORTED error directive, script was crashing:

[Error] : #35: #error directive: [NOT_SUPPORTED]
Traceback (most recent call last):
File "tools/singletest.py", line 262, in
if (singletest_in_cli_mode(single_test)):
File "C:\github\mbed\tools\test_api.py", line 1545, in singletest_in_cli_mode
test_summary, shuffle_seed, test_summary_ext, test_suite_properties_ext, build_report, build_properties = single_test.execute()
File "C:\github\mbed\tools\test_api.py", line 649, in execute
self.execute_thread_slice(q, target, toolchains, clean, test_ids, self.build_report, self.build_properties)
File "C:\github\mbed\tools\test_api.py", line 529, in execute_thread_slice
print(elf.logger.log_line(
NameError: global name 'elf' is not defined

@theotherjimmy

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 17, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 17, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 20, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 20, 2018

Build : SUCCESS

Build number : 2074
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6939/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented May 21, 2018

Hi
Please add this patch in the next os2 release version.

@adbridge adbridge added ready for merge and removed needs: CI labels May 21, 2018

@cmonr cmonr merged commit 1ae48fc into ARMmbed:master May 21, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 845 warnings (+0 warnings)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10892 cycles (+1930 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_NOT_SUPPORTED branch May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment