New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVStore - remove Thread.h include #6940

Merged
merged 1 commit into from May 18, 2018

Conversation

Projects
None yet
5 participants
@JanneKiiskila
Contributor

JanneKiiskila commented May 17, 2018

Description

Remove include of Thread.h as this include is not actually needed.
Having it will cause issues with the bootloader size, as this will cause
a need to get the full CMSIS/RTOS package etc., which would bloat
the bootloader size.

Minor fix, bootloader compiles with Mbed Cloud supported boards.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
NVStore - remove Thread.h include
As this include is not actually needed. Having it will cause issues
with the bootloader, as this will cause a need to get the full
CMSIS/RTOS package etc., which would bloat the bootloader size.
@JanneKiiskila

This comment has been minimized.

Contributor

JanneKiiskila commented May 17, 2018

@davidsaada

This comment has been minimized.

Contributor

davidsaada commented May 17, 2018

Looks good to me. Include is there by accident probably - no usage of threads in NVStore.

@0xc0170 0xc0170 requested a review from davidsaada May 17, 2018

@davidsaada

Looks good to me.

@JanneKiiskila

This comment has been minimized.

Contributor

JanneKiiskila commented May 17, 2018

We would want this to the next patch release, please.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 17, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 17, 2018

Build : SUCCESS

Build number : 2051
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6940/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 18, 2018

Launching this again.
Amidst the sea of "license is expiring" errors, this one error stuck out:

A1023E: File "/tmp/fileFp0UTL" could not be opened: No such file or directory
1 Error, 1 Warning

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 18, 2018

@0xc0170 0xc0170 merged commit 79640c6 into ARMmbed:master May 18, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 845 warnings (+0 warnings)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8694 cycles (-268 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment