New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Unit tests fixes #6965

Merged
merged 3 commits into from May 29, 2018

Conversation

Projects
None yet
7 participants
@mirelachirica
Contributor

mirelachirica commented May 21, 2018

Description

Fixes for following issues:

  • missing rtos::Thread::wait_until stub after such call was introduced to ATHandler
  • missing poll_stub setting for reading routines after poll(...) replaced the filehandle read loop in ATHandler
  • wrong location for unit test's mbed_retarget.h and missing sys/types.h include for ssize_t type

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@mirelachirica

This comment has been minimized.

Contributor

mirelachirica commented May 21, 2018

@jarvte and @AriParkkila please review this

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-wan May 22, 2018

@@ -0,0 +1,13 @@
#ifndef CMSIS_OS_H_

This comment has been minimized.

@jarvte

jarvte May 22, 2018

Contributor

Missing copyrights.

@@ -0,0 +1 @@
#define OS_STACK_SIZE 0

This comment has been minimized.

@jarvte

jarvte May 22, 2018

Contributor

Missing copyrights.

@@ -0,0 +1 @@
typedef void* Mutex;

This comment has been minimized.

@jarvte

jarvte May 22, 2018

Contributor

Missing copyrights.

@@ -0,0 +1 @@
typedef void* Semaphore;

This comment has been minimized.

@jarvte

jarvte May 22, 2018

Contributor

Missing copyrights.

@mirelachirica

This comment has been minimized.

Contributor

mirelachirica commented May 23, 2018

I'm going to rebase.

@mirelachirica mirelachirica dismissed stale reviews from AnttiKauppila and jarvte via 853c4c6 May 23, 2018

@mirelachirica mirelachirica force-pushed the mirelachirica:fix_unittests branch from e56f4ba to 853c4c6 May 23, 2018

@mirelachirica

This comment has been minimized.

Contributor

mirelachirica commented May 28, 2018

Who's review is needed for this to proceed?

@AnttiKauppila

This comment has been minimized.

Contributor

AnttiKauppila commented May 28, 2018

@jarvte is on sick leave, but his comment has been addressed. This is ready to be merged

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 28, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 28, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 28, 2018

Build : SUCCESS

Build number : 2181
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6965/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@AnttiKauppila

This comment has been minimized.

Contributor

AnttiKauppila commented May 29, 2018

@0xc0170 Can you retrigger failed test. For some reason NRF51_DK timed out.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 29, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 206cab9 into ARMmbed:master May 29, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 850 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8828 cycles (-615 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment