New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to EFM32 port #6970

Merged
merged 2 commits into from May 29, 2018

Conversation

Projects
None yet
4 participants
@stevew817
Contributor

stevew817 commented May 21, 2018

Description

  • Minimum write size was incorrectly being reported as a whole page, instead of the actual write unit of 32-bit
  • Flash API was running as ramfunc by default, whereas mbed doesn't have a need for that
  • Moved pin PF7 for SPI from SPI_1 to SPI_2 to accomodate updated TB_SENSE_12 pinout
  • Updated TB_SENSE_12 EXP pin assignments to match the production revision of the board instead of pre-production

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@0xc0170

Fixes look good but would be better if they come as separate commits (flash fixes, pins fix). Please split those 2

@0xc0170 0xc0170 added the needs: work label May 22, 2018

stevew817 added some commits May 22, 2018

Update pinout of TB_SENSE_12 to production revision
* Updated pinout of EXP header from pre-production to production
* Move assignment of PF7 to SPI_2 to be compatible with the new SPI flash routing
Fix to flash API on EFM32
* Since mbed does not overwrite itself, make the flashing routines run out of flash by default
* Report a writeable size of 4 bytes (previously erroneously reported a full eraseable page as the minimum write size)

@stevew817 stevew817 force-pushed the stevew817:efm32_flash_bugfix branch from b6eed0a to c2bc20e May 22, 2018

@stevew817

This comment has been minimized.

Contributor

stevew817 commented May 22, 2018

@0xc0170 Commits are now split

@stevew817

This comment has been minimized.

Contributor

stevew817 commented May 28, 2018

@0xc0170 Can you move this along, please? I split up the commits as you requested.

@0xc0170 0xc0170 added needs: review and removed needs: work labels May 28, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 28, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 28, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 28, 2018

Build : SUCCESS

Build number : 2175
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6970/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 29, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 29, 2018

@cmonr cmonr merged commit 1a0c2d0 into ARMmbed:master May 29, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 847 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10191 cycles (+183 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label May 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment