New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support default tz_module in event loop thread for M23/M33 #6978

Merged
merged 1 commit into from Jun 11, 2018

Conversation

Projects
None yet
6 participants
@cyliangtw
Contributor

cyliangtw commented May 22, 2018

Description

Thread class could support default tz_module of Thread attribute for M23/M33 in #6486 , however event loop & lwip will create new thread by osThreadNew(...) directly. So, to apply the same mechanism of #6486 on these 2 features. To allow event-queue's non-secure task to access secure functions.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@deepikabhavnani

@deepikabhavnani

Looks good to me 👍

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 29, 2018

@SeppoTakalo @kjbracey-arm If y'all could check the two files, that would be great.

On quick glance, (and thank you for the referenced PR @cyliangtw) this looks fine to me.

@0xc0170

0xc0170 approved these changes Jun 6, 2018

@cmonr cmonr added needs: CI and removed needs: review labels Jun 6, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 7, 2018

/morph build

1 similar comment
@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 7, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 7, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 7, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 7, 2018

Halting CI builds until RC3 PRs are completed. Will resume after.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 9, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 9, 2018

Build : SUCCESS

Build number : 2294
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6978/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 3206b81 into ARMmbed:master Jun 11, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 845 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10291 cycles (+677 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment