New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devicekey example to examples list #7003

Merged
merged 2 commits into from May 25, 2018

Conversation

Projects
None yet
7 participants
@adbridge
Contributor

adbridge commented May 24, 2018

Description

This PR adds the mbed-os-example-devicekey to the list of examples.
This can only go in after the device key feature has been merged.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[x] Feature
[ ] Breaking change

@adbridge adbridge requested a review from 0xc0170 May 24, 2018

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-storage May 24, 2018

@0xc0170

Looks fine to me. I requested @yossi2le to confirm this is valid (please review features/targets) for this example

@yossi2le

This comment has been minimized.

Contributor

yossi2le commented May 24, 2018

Looks fine to me also. DeviceKey should support all targets and has no dependencies in spacial features.

@davidsaada

Looks good to me.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 24, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 24, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 24, 2018

@adbridge @davidsaada @yossi2le Please take a look at the failures.

Judging by the patterns and taking a quick look, it looks like there might be a minimum size requirement of some sort.

@cmonr cmonr added needs: work and removed needs: CI labels May 24, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 24, 2018

The quickest way to resolve this would probably be to explicitly list the devices that this example supports by adding them into the '"targets" : []` array.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 24, 2018

@adbridge

This comment has been minimized.

Contributor

adbridge commented May 24, 2018

If one of you devicekey experts can list the supported targets I can add them to the target list.

@geky

This comment has been minimized.

Member

geky commented May 24, 2018

At minimum I believe this can include K64F:
#6919

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 24, 2018

@yossi2le Is Flash iAP a requirement for this example to work?

If so, I know of at least two devices that will not work with this example: #6925

@yossi2le

This comment has been minimized.

Contributor

yossi2le commented May 24, 2018

@cmonr @adbridge @geky
Sorry for that. I thought the nvstore dependencies will be taken care of.
The target list should be the same as in nvstore example. checking it shows that the nvstore example target is only K64F :(.

@yossi2le

This comment has been minimized.

Contributor

yossi2le commented May 24, 2018

@geky, @cmonr , @adbridge
Reflecting on it again I need your opinion. The nvstore is depends on DEVICE_FLASH and where we have nvstore we can have device key. While device key example is binded to nvstore it actually may run on more platforms. Looking on the build which fails we also have lots of devices that pass and device key will work on those. What do you think?

This is the list of device that passed the build.

ARCH_PRO, B96B_F446VE, DELTA_DFBM_NQ620, DISCO_F413ZH, DISCO_F429ZI, DISCO_F469NI, DISCO_F746NG, DISCO_F769NI, DISCO_L072CZ_LRWAN1, DISCO_L475VG_IOT01A, DISCO_L476VG, DISCO_L496AG, EFM32GG_STK3700, EFM32LG_STK3600, EFM32PG12_STK3402, EFM32PG_STK3401, EFM32WG_STK3800, EV_COG_AD3029LZ, EV_COG_AD4050LZ, FF1705_L151CC, FF_LPC546XX, HEXIWEAR, K64F, K66F, K82F, KL46Z, KW24D, LPC1768, LPC1769, LPC54114, LPC546XX, MBED_CONNECT_ODIN, MTB_ADV_WISE_1510, MTB_ADV_WISE_1530, MTB_ADV_WISE_1570, MTB_LAIRD_BL652, MTB_MTS_XDOT, MTB_MURATA_ABZ, MTB_MXCHIP_EMW3166, MTB_UBLOX_NINA_B1, MTB_UBLOX_ODIN_W2, MTB_USI_WM_BN_BM_22, NRF52840_DK, NRF52_DK, NUCLEO_F070RB, NUCLEO_F072RB, NUCLEO_F091RC, NUCLEO_F103RB, NUCLEO_F207ZG, NUCLEO_F303RE, NUCLEO_F303ZE, NUCLEO_F401RE, NUCLEO_F410RB, NUCLEO_F411RE, NUCLEO_F412ZG, NUCLEO_F413ZH, NUCLEO_F429ZI, NUCLEO_F439ZI, NUCLEO_F446RE, NUCLEO_F446ZE, NUCLEO_F746ZG, NUCLEO_F756ZG, NUCLEO_F767ZI, NUCLEO_L073RZ, NUCLEO_L152RE, NUCLEO_L432KC, NUCLEO_L433RC_P, NUCLEO_L476RG, NUCLEO_L486RG, NUCLEO_L496ZG, NUCLEO_L496ZG_P, NUMAKER_PFM_M453, NUMAKER_PFM_M487, NUMAKER_PFM_NUC472, RBLAB_BLENANO2, REALTEK_RTL8195AM, RO359B, SILICA_SENSOR_NODE, STEVAL_3DP001V1, TB_SENSE_1, TB_SENSE_12, TMPM46B, UBLOX_C027, UBLOX_C030_N211, UBLOX_C030_R410M, UBLOX_C030_U201, UBLOX_EVA_NINA, UBLOX_EVK_NINA_B1, UBLOX_EVK_ODIN_W2, UBRIDGE, USI_WM_BN_BM_22, VBLUNO52, XDOT_L151CC,

@geky

This comment has been minimized.

Member

geky commented May 24, 2018

Sounds like we should add those devices as targets for NVStore and DeviceKey? @adbridge, @cmonr, thoughts?

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 24, 2018

It's fine by me if all of those are listed as example targets for both examples.

@yossi2le

This comment has been minimized.

Contributor

yossi2le commented May 24, 2018

Nvstore is actually suppose to work on all platforms which has DEVICE_FLASH and where there is nvstore there is also device key. With that said @davidsaada is the nvstore example owner so I can't speak on is behalf

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 24, 2018

Let's do this. In order to get this in for 5.9, and keep it in line with what exists right now, we'll just add the K64F as a target.

I have a feeling that the features: [] array is suppose to contain DEVICE_FLASH, but with less than a day before code freeze, I'd much prefer to go the route of getting this in in a known way, and having a 'fix' PR come in later.

Since @adbridge is afk, I'll resubmit this PR, only adding the K64F as a target.

Limit devicekey example to only K64F
Lines up devicekey example with nvstore example

@cmonr cmonr dismissed stale reviews from davidsaada and 0xc0170 via 322c95c May 24, 2018

@cmonr cmonr requested a review from geky May 24, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 24, 2018

Made the change without a new PR :D

@geky @0xc0170 @adbridge @yossi2le @davidsaada All good?

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 24, 2018

Going to restart CI.

/morph build

@yossi2le

This comment has been minimized.

Contributor

yossi2le commented May 24, 2018

I absolutely agree. @cmonr thx.

@mbed-ci

This comment has been minimized.

mbed-ci commented May 24, 2018

Build : SUCCESS

Build number : 2143
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7003/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@cmonr cmonr added needs: CI and removed needs: work labels May 25, 2018

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

@yossi2le Need an action to review features/targets for this one.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 25, 2018

@yossi2le

This comment has been minimized.

Contributor

yossi2le commented May 25, 2018

I don't know why but I don't have permission to do so. The approve dialog is missing. I will ask @davidsaada to do so.

@adbridge

This comment has been minimized.

Contributor

adbridge commented May 25, 2018

@yossi2le @cmonr Thanks for that list. The targets list in the example file wasn't generally designed to have that many targets in it (though it still should work). I agree with @cmonr that just adding K64F for now is the right way forward and then we need to look at this more carefully for 5.9.1.

@adbridge adbridge added the risk: G label May 25, 2018

@0xc0170 0xc0170 merged commit 54ac90f into ARMmbed:master May 25, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 906 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10071 cycles (-152 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment