New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Fix AT URC handler not to dismiss incoming chars #7033

Merged
merged 1 commit into from May 29, 2018

Conversation

Projects
None yet
5 participants
@AriParkkila
Contributor

AriParkkila commented May 28, 2018

Description

Fixes AT URC handler to not miss URC in a case when a part of that was received just before URC timeout expired, for example:

I------------I-------------I
NO CARRIER

This fix depends on PR #7030.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-wan May 28, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 28, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 28, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 28, 2018

Build : SUCCESS

Build number : 2182
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7033/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@AnttiKauppila

This comment has been minimized.

Contributor

AnttiKauppila commented May 29, 2018

@0xc0170 This is ready to go in

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 29, 2018

@cmonr cmonr merged commit 0f41831 into ARMmbed:master May 29, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 908 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9945 cycles (-68 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@AriParkkila AriParkkila deleted the AriParkkila:cellular-at-fix branch May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment