New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: BC95 socket creation to fail on missing socket id in the re… #7052

Merged
merged 1 commit into from Jun 1, 2018

Conversation

Projects
None yet
6 participants
@mirelachirica
Contributor

mirelachirica commented May 30, 2018

…sponse

Description

For BC95 modem, socket creation AT command is found to return OK without the socket id. In this case socket id returned by at handler on read_int() is -1 which is invalid id to be used so socket creation should report failure in this case.
"OK without socket id" is an abnormal response and will need to be investigated further. In case the socket id part of the response is not lost on our side(serial/athandler) issue has to be raised to manufacturer.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-wan May 30, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 30, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 30, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 30, 2018

Build : SUCCESS

Build number : 2193
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7052/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 31, 2018

/morph test

@mbed-ci

This comment has been minimized.

@adbridge adbridge self-requested a review Jun 1, 2018

@adbridge

Approving on behalf of maintainers

@adbridge adbridge added ready for merge and removed needs: CI labels Jun 1, 2018

@adbridge adbridge merged commit b5b306e into ARMmbed:master Jun 1, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 918 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10166 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@mirelachirica mirelachirica deleted the mirelachirica:bc95_sock_id_fix branch Jun 5, 2018

@mirelachirica mirelachirica restored the mirelachirica:bc95_sock_id_fix branch Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment