New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant Cryptocell libraries #7074

Merged
merged 1 commit into from Jun 4, 2018

Conversation

Projects
None yet
4 participants
@RonEld
Contributor

RonEld commented May 31, 2018

Description

Remove additional redundant libraries, that were accidentally added in the CC310 porting PR.
Addresses #7069

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Remove redundant Cryptocell libraries
Remove additional redundant libraries, that were accidently added in merges
@cmonr

This comment has been minimized.

Contributor

cmonr commented May 31, 2018

@RonEld Why were these files introduced with #6794 in the first place?

@cmonr cmonr self-requested a review May 31, 2018

@RonEld

This comment has been minimized.

Contributor

RonEld commented Jun 3, 2018

@cmonr They were added by mistake, within all the rebases and merges that were done. And they were missed in the reviews

@cmonr cmonr added the needs: CI label Jun 3, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 3, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 3, 2018

Build : SUCCESS

Build number : 2226
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7074/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@RonEld

This comment has been minimized.

Contributor

RonEld commented Jun 4, 2018

@cmonr Note that this PR addresses only part of #7069
It doesn't resolve the first part of that issue

@0xc0170

0xc0170 approved these changes Jun 4, 2018

@cmonr cmonr merged commit 0ae41b1 into ARMmbed:master Jun 4, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 919 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9852 cycles (+966 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment