New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EFM32GG11 #7079

Merged
merged 2 commits into from Jul 13, 2018

Conversation

@stevew817
Contributor

stevew817 commented May 31, 2018

Description

Adding in support for EFM32GG11 - STK3701 (https://www.silabs.com/products/development-tools/mcu/32-bit/efm32-giant-gecko-gg11-starter-kit) as a target, now that the EMAC changes have made their way to master.

What's supported with this PR

  • Core mbed-os support (ADC/serial/SPI/I2C/tickless/PWM/GPIO/RTC/lowpower timer)
  • mbedTLS hardware acceleration support (AES-128/256, SHA-1/2, ECC secp192/224/256, TRNG)
  • Ethernet (EMAC driver)

Missing board features

  • SD slot is not supported, since it is hardwired to the chip's SDIO peripheral. mbed-os does not support SDIO AFAIK.
  • On-board SPI flash is hardwired to the chip's QSPI peripheral. This functionality needs the QSPI HAL in order to be ported. @0xc0170 do you have a timeline for that addition?

Test results

Test results

Pull request type

[ ] Fix
[ ] Refactor
[X] New target
[ ] Feature
[ ] Breaking change

@stevew817 stevew817 force-pushed the SiliconLabs:feature/EFM32GG11-OS5.9 branch from 786279e to 1696069 May 31, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 4, 2018

Travis doxygen failure is related to the docs , please review.

@0xc0170 0xc0170 requested review from ARMmbed/mbed-os-hal Jun 4, 2018

@stevew817 stevew817 force-pushed the SiliconLabs:feature/EFM32GG11-OS5.9 branch from 6908a18 to da991ad Jun 4, 2018

@stevew817

This comment has been minimized.

Contributor

stevew817 commented Jun 4, 2018

@0xc0170 fixed :)

@@ -0,0 +1,25 @@
#ifndef SL_EMAC_CONFIG_H

This comment has been minimized.

@0xc0170

0xc0170 Jun 6, 2018

Member

license missing here

@@ -0,0 +1,22 @@
#ifndef SL_ETH_HW_H

This comment has been minimized.

@0xc0170

0xc0170 Jun 6, 2018

Member

missing license here

@0xc0170 0xc0170 added needs: work and removed needs: review labels Jun 6, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 13, 2018

On-board SPI flash is hardwired to the chip's QSPI peripheral. This functionality needs the QSPI HAL in order to be ported. @0xc0170 do you have a timeline for that addition?

cc @bulislaw

@bulislaw

This comment has been minimized.

Member

bulislaw commented Jun 13, 2018

Hope we can get it in for 5.10. Let me try again to get the things moving.

@stevew817 stevew817 force-pushed the SiliconLabs:feature/EFM32GG11-OS5.9 branch from da991ad to 8439754 Jun 14, 2018

@stevew817

This comment has been minimized.

Contributor

stevew817 commented Jun 14, 2018

@0xc0170 Licenses are now correctly applied

@cmonr cmonr added needs: review and removed needs: work labels Jun 14, 2018

Licenses updated.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 19, 2018

Man is this a feature-filled target.

@ARMmbed/mbed-os-hal @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-tls
Thoughts on at least sections of this PR?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 20, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 20, 2018

@cmonr cmonr added needs: work and removed needs: review labels Jun 20, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 21, 2018

Please review the latest test results - fails to find malloc.h file?

@KariHaapalehto

This comment has been minimized.

Contributor

KariHaapalehto commented Jun 21, 2018

Failing seems to happen with USI_WM_BN_BM_22-target, which is meant to be base target for MTB_USI_WM_BN_BM_22 and MTB_ADV_WISE_1530.
MTB_USI_WM_BN_BM_22 and MTB_ADV_WISE_1530 are inheriting USI_WM_BN_BM_22,
so USI_WM_BN_BM_22 is not meant to be real target. I'll add the:
"public": false
to target.json

@cmonr cmonr added the needs: work label Jul 11, 2018

@stevew817 stevew817 force-pushed the SiliconLabs:feature/EFM32GG11-OS5.9 branch from f393cd2 to 7aeacfa Jul 11, 2018

@stevew817

This comment has been minimized.

Contributor

stevew817 commented Jul 11, 2018

Well, that was an unfortunate surprise. I guess having the PR open for this long does make it prone to master being a very moving target.

Rebased to master and fixed. Should be passing now. @cmonr

@stevew817 stevew817 force-pushed the SiliconLabs:feature/EFM32GG11-OS5.9 branch from 7aeacfa to da377c6 Jul 11, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 11, 2018

/morph build

@cmonr cmonr added needs: CI and removed needs: work labels Jul 11, 2018

@cmonr

cmonr approved these changes Jul 11, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 11, 2018

Build : SUCCESS

Build number : 2576
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7079/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 12, 2018

Test errors not related, we will investigate

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 12, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 13, 2018

Full rebuild needed

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 13, 2018

Build : SUCCESS

Build number : 2596
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7079/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 602b0ce into ARMmbed:master Jul 13, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 794 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9560 cycles (-42 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Jul 13, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 19, 2018

Damn it. Because this was closed and re-opened, the PR lost the release tag, and we brought it in without one, meaning it missed the 5.9.3 release...

At least now it'll be in 5.9.4.
@ARMmbed/mbed-os-maintainers we missed one :/

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment