New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mbed_crc_ctor is missing in some MbedCRC constructor #7081

Merged
merged 1 commit into from Jun 5, 2018

Conversation

Projects
None yet
5 participants
@ccli8
Contributor

ccli8 commented Jun 1, 2018

Description

This fixes the error which leaves MbedCRC/_mode uninitialized and may cause mbed-os-tests-mbed_drivers-crc/Test SD CRC polynomials failed.

Related PR

#7066

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Fix mbed_crc_ctor is missing in some MbedCRC constructor
This error leaves MbedCRC/_mode uninitialized and may cause mbed-os-tests-mbed_drivers-crc/
Test SD CRC polynomials failed.
@0xc0170

0xc0170 approved these changes Jun 4, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jun 4, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 4, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 4, 2018

Build : SUCCESS

Build number : 2230
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7081/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit 74aec93 into ARMmbed:master Jun 5, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 919 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10181 cycles (+581 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Jun 5, 2018

@ccli8 ccli8 deleted the OpenNuvoton:nuvoton_fix_crc branch Jun 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment