New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE fixes (SM whitelist creation, Nordic scatter file fix, missing TLS initialisation) #7089

Merged
merged 5 commits into from Jun 4, 2018

Conversation

Projects
None yet
6 participants
@paul-szczepanek-arm
Member

paul-szczepanek-arm commented Jun 1, 2018

Description

Whitelist creation did not update the size making the consumer think no items where created (original PR: paul-szczepanek-arm#54).

Place observers sequentially in flash in the scatter file for Nordic (original PR: paul-szczepanek-arm#57).

Missing TLS initialisation (original PR: paul-szczepanek-arm#56).

MBED_ASSERT had the wrong condition, creating a false assert when ran in debug.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@paul-szczepanek-arm paul-szczepanek-arm requested review from pan- and donatieng Jun 1, 2018

@paul-szczepanek-arm paul-szczepanek-arm changed the title from Fix whitelist creation and fix erroneous assert to BLE fixes (SM whitelist creation, Nordic scatter file fix) Jun 1, 2018

@paul-szczepanek-arm paul-szczepanek-arm changed the title from BLE fixes (SM whitelist creation, Nordic scatter file fix) to BLE fixes (SM whitelist creation, Nordic scatter file fix, missing TLS initialisation) Jun 1, 2018

@donatieng

This comment has been minimized.

Member

donatieng commented Jun 1, 2018

This is targeting mbed OS 5.9 RC2.

One more fix on its way for #7006, please do not merge for now

@donatieng

This comment has been minimized.

Member

donatieng commented Jun 1, 2018

Actually looks like #7006 does not need further fixing, so this PR is good to go!

@pan-

pan- approved these changes Jun 1, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 2, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 2, 2018

Build : SUCCESS

Build number : 2224
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7089/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 3, 2018

/morph uvisor-test

1 similar comment
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 4, 2018

/morph uvisor-test

@0xc0170

0xc0170 approved these changes Jun 4, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 4, 2018

/morph uvisor-test

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 4, 2018

@orenc17 Please check CI uvisor for this PR

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 4, 2018

@cmonr cmonr merged commit 20a4412 into ARMmbed:master Jun 4, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 919 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9384 cycles (-193 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment