New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cellular tests #7102

Merged
merged 3 commits into from Jun 14, 2018

Conversation

Projects
None yet
6 participants
@jarvte
Contributor

jarvte commented Jun 4, 2018

Description

  • Added greentea tests for CellularDevice
  • Added cellular unit tests for CellularDevice API
  • Fixed unit test failures in master

Internal ref to defect: IOTCELL-884-893

@mirelachirica @AnttiKauppila please review

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-wan Jun 4, 2018

@jarvte

This comment has been minimized.

Contributor

jarvte commented Jun 5, 2018

@0xc0170 Something wrong in ci pr-head which is not related to this pr

@jarvte

This comment has been minimized.

Contributor

jarvte commented Jun 7, 2018

@0xc0170 please proceed as this commit is used as a base for adding more tests.

@jarvte

This comment has been minimized.

Contributor

jarvte commented Jun 11, 2018

@0xc0170 could you please trigger the tests?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 11, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jun 11, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 11, 2018

Build : SUCCESS

Build number : 2317
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7102/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@@ -18,8 +18,6 @@
#ifndef CELLULAR_LOG_H_
#define CELLULAR_LOG_H_
#include "rtos.h"

This comment has been minimized.

@cmonr

cmonr Jun 11, 2018

Contributor

What's the reason for removing this include?

This comment has been minimized.

@jarvte

jarvte Jun 12, 2018

Contributor

It was unnecessary include which caused problems with stubbing the classes

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@jarvte

This comment has been minimized.

Contributor

jarvte commented Jun 12, 2018

@cmonr I guess co-morph-test failure not related to this pr:

mbedgt: all tests finished!
23:24:49 mbedgt: shuffle seed: 0.1076850944
23:24:49 mbedgt: exporting to JUNIT file '/home/jenkins/k64f_test/workspace/test_matrix_raas/raas_matrix_job/target/MAX32630FTHR/toolchain/IAR/test_report_MAX32630FTHR-IAR.xml'...
23:24:50 mbedgt: exporting to HTML file '/home/jenkins/k64f_test/workspace/test_matrix_raas/raas_matrix_job/target/MAX32630FTHR/toolchain/IAR/test_report_MAX32630FTHR-IAR.html'...
23:24:50 mbedgt: unexpected error:
23:24:50 'time_start'
23:24:50 Traceback (most recent call last):
23:24:50 File "/usr/local/bin/mbedgt", line 9, in
23:24:50 load_entry_point('mbed-greentea==1.3.3', 'console_scripts', 'mbedgt')()
23:24:50 File "/home/shrtud01/greentea/mbed_greentea/mbed_greentea_cli.py", line 411, in main
23:24:50 cli_ret = main_cli(opts, args)
23:24:50 File "/home/shrtud01/greentea/mbed_greentea/mbed_greentea_cli.py", line 1063, in main_cli
23:24:50 html_report = exporter_html(test_report)
23:24:50 File "/home/shrtud01/greentea/mbed_greentea/mbed_report_api.py", line 755, in exporter_html
23:24:50 test_results)
23:24:50 File "/home/shrtud01/greentea/mbed_greentea/mbed_report_api.py", line 644, in get_result_overlay
23:24:50 overlay_dropdowns = get_result_overlay_dropdowns(result_div_id, test_results)
23:24:50 File "/home/shrtud01/greentea/mbed_greentea/mbed_report_api.py", line 612, in get_result_overlay_dropdowns
23:24:50 result_overlay_dropdowns = result_output_dropdown + get_result_overlay_testcases_dropdown_menu(result_div_id, test_results)
23:24:50 File "/home/shrtud01/greentea/mbed_greentea/mbed_report_api.py", line 584, in get_result_overlay_testcases_dropdown_menu
23:24:50 testcase_results_info += get_result_overlay_testcase_dropdown(result_div_id, index, testcase_result_name, testcase_result)
23:24:50 File "/home/shrtud01/greentea/mbed_greentea/mbed_report_api.py", line 557, in get_result_overlay_testcase_dropdown
23:24:50 datetime.datetime.fromtimestamp(testcase_result['time_start']).strftime('%d-%m-%Y %H:%M:%S.%f'),
23:24:50 KeyError: 'time_start'

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 12, 2018

@jarvte That looks correct, I noticed this just now in another PR as well. I notified @studavekar

I do not restart Ci immediately, waiting for current test to complete (if it fails or not)

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 12, 2018

We're looking into some CI issues at the moment. The test will be restarted when the dust has settled.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 13, 2018

/morph test

@mbed-ci

This comment has been minimized.

@jarvte

This comment has been minimized.

Contributor

jarvte commented Jun 14, 2018

@cmonr Please merge so other can use this as a base for future tests.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 14, 2018

@cmonr cmonr merged commit c82af3d into ARMmbed:master Jun 14, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 922 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9925 cycles (+904 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@jarvte jarvte deleted the jarvte:adding_cellular_tests branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment