New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool: Use TerminalNotifier in singletest #7124

Merged
merged 1 commit into from Jun 7, 2018

Conversation

Projects
None yet
6 participants
@theotherjimmy
Contributor

theotherjimmy commented Jun 5, 2018

Description

According to #6914 comment thread, singletest did not get updated with the rest
of the tools in the notifier refactor. I thought this was because it's a
deprecated tool without users. We have a user, so we have a fix.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@jeromecoutant

Please include this PR before next OS2 label
Thx

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 6, 2018

@jeromecoutant So this resolves your errors?

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Jun 6, 2018

Yes, I can make OS2 tests again
Thx

@0xc0170

0xc0170 approved these changes Jun 6, 2018

Not certain if I left a comment here , github does not show it at the moment. @cmonr made one more additional commit to fix mbed 2 build, do we need to add it here or all good?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 6, 2018

@0xc0170 See: #7132 (comment)

Tl;dr: Nope.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 6, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 7, 2018

Build : SUCCESS

Build number : 2257
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7124/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Jun 7, 2018

@cmonr cmonr merged commit 7dc4848 into ARMmbed:master Jun 7, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 920 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10180 cycles (+599 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment