New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flash_program_page API in LPC boards. #7128

Merged
merged 1 commit into from Jun 15, 2018

Conversation

Projects
None yet
6 participants
@davidsaada
Contributor

davidsaada commented Jun 5, 2018

Description

This PR fixes the flash_program_page API in LPC boards.
This API allocates a program buffer of 256 on the stack to ensure alignment.
However, FlashIAP driver already ensures this alignment of the user data, so this allocation is redundant.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/team-nxp Jun 5, 2018

@mmahadevan108

Agree. This operation is redundant as a check is present in the driver to ensure address is page aligned.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jun 11, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 11, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 11, 2018

Build : SUCCESS

Build number : 2320
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7128/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

Fix flash_program_page API in LPC boards.
This API allocates a program buffer of 256 on the stack to ensure alignment.
However, FlashIAP driver already ensures this alignment of the user data.

@davidsaada davidsaada dismissed stale reviews from mmahadevan108 and 0xc0170 via 9e5efbc Jun 12, 2018

@davidsaada davidsaada force-pushed the davidsaada:david_lpc_flash_api_fix branch from 9950a2f to 9e5efbc Jun 12, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 12, 2018

@davidsaada The latest commit fixes the test failure (helps if you comment on any change in the PR to provide actual status)

@davidsaada

This comment has been minimized.

Contributor

davidsaada commented Jun 12, 2018

(@0xc0170 was just about to - you beat me up to it...)
Removed a test checking that programming succeeds if buffer is unaligned in the hal level, which is just what this fix changes.

@0xc0170

Just to confirm - the headline is for LPC fix but I can see functional test case removal - is this because test is actually always passed or ?

@davidsaada

This comment has been minimized.

Contributor

davidsaada commented Jun 13, 2018

Just to confirm - the headline is for LPC fix but I can see functional test case removal - is this because test is actually always passed or ?

It is because FlashIAP makes sure that user data is aligned, no need to take care of it in HAL layer (which is what the test checked). LPC allocated a lot of stack for this purpose (keeping user data aligned at HAL layer), which is exactly what this PR fixed.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 14, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 14, 2018

Build : SUCCESS

Build number : 2352
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7128/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@adbridge adbridge added ready for merge and removed needs: CI labels Jun 15, 2018

@adbridge adbridge merged commit 245a9aa into ARMmbed:master Jun 15, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 922 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9777 cycles (+646 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@davidsaada davidsaada deleted the davidsaada:david_lpc_flash_api_fix branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment