New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for RZ_A1H issue 6543 #7151

Merged
merged 1 commit into from Jun 13, 2018

Conversation

Projects
None yet
8 participants
@mrcoulter45
Contributor

mrcoulter45 commented Jun 6, 2018

Description

Code to fix build errors in issue 6543.
I have put debugging code in my remote https://github.com/mrcoulter45/mbed-os in the issue6543_debug branch. That code will build Blinky for the RZ_A1H with GCC_ARM and should be a good starting point for those who are implementing the low power ticker. In the debug code, the us ticker is being used as a substitute for the lp ticker.

Pull request type

[ x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@@ -20,12 +20,23 @@
* SOFTWARE.
*/
#include "rtos/TARGET_CORTEX/SysTimer.h"
#include "cmsis/TARGET_CORTEX_A/irq_ctrl.h"

This comment has been minimized.

@0xc0170

0xc0170 Jun 7, 2018

Member

this header file is not available for all cortex thus should be protected somehow. Thinking, isn't this irq_ctrl.h available via RTE_Components or CMSIS_device_header (in our case is it cmsis.h file) ?

I assume the same lines as in rtos/TARGET_CORTEX/mbed_rtx_idle.cpp would do the job here

This comment has been minimized.

@mrcoulter45

mrcoulter45 Jun 8, 2018

Contributor

This should be fixed now.

void OS_Tick_Enable (void)
{
// Enable OS Tick.
// void OS_Tick_Enable (void)

This comment has been minimized.

@0xc0170

0xc0170 Jun 7, 2018

Member

are these SDK files (thus only commented out) ? The ideal would be to have this removed, but if there is a reason to leave this dead code?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 7, 2018

@mrcoulter45 Nitpick on the description: you can enable "device has", but they can't be enabled for a particular toolchain. You may want to remove the mention of GCC_ARM from the description. Maybe you were trying to say that you verified with GCC_ARM?

@0xc0170

Changes look fine, but please remove the merge commit (cleanly rebase). This is a small changeset, one commit should be sufficient

@mrcoulter45 mrcoulter45 force-pushed the mrcoulter45:issue6543 branch 4 times, most recently from 1c71c6b to 8ece0f1 Jun 11, 2018

Fixes for RZ_A1H issue 6543
Removed debugging code, fixed errors indicated in the comments.

@mrcoulter45 mrcoulter45 force-pushed the mrcoulter45:issue6543 branch from 8ece0f1 to 3d3e890 Jun 11, 2018

Requests were addressed.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 12, 2018

/morph build

@cmonr

cmonr approved these changes Jun 12, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 12, 2018

Build : SUCCESS

Build number : 2329
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7151/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 12, 2018

/morph mbed2-build

@TomoYamanaka

LGTM

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jun 12, 2018

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 12, 2018

Node failure, restarting

/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Jun 13, 2018

@cmonr cmonr merged commit 1cb298a into ARMmbed:master Jun 13, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 921 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9600 cycles (+17 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment