New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data aligment problem at STM32F4 hash write #7176

Merged
merged 1 commit into from Jun 12, 2018

Conversation

Projects
None yet
7 participants
@KariHaapalehto
Contributor

KariHaapalehto commented Jun 8, 2018

Description

Fix data aligment error what were seen with ARM compiler and release profile.
The fix has been tested with GCC_ARM, ARM and IAR compilers using both release and debug profiles. No regression were seen.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Jun 8, 2018

ST_INTERNAL_REF 48706

@0xc0170 0xc0170 requested a review from ARMmbed/team-st-mcd Jun 8, 2018

@bcostm

bcostm approved these changes Jun 11, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jun 11, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 11, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 11, 2018

Build : SUCCESS

Build number : 2313
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7176/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 8987631 into ARMmbed:master Jun 12, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 920 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10172 cycles (+1343 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Jun 12, 2018

@KariHaapalehto KariHaapalehto deleted the KariHaapalehto:data_aligment branch Jun 12, 2018

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Jun 13, 2018

Hi @KariHaapalehto

Fix data aligment error what were seen with ARM compiler and release profile.

ST driver team would need more details about error you have seen.
Is it some test error, compilation error ?
Thx

@KariHaapalehto

This comment has been minimized.

Contributor

KariHaapalehto commented Jun 13, 2018

This is not test nor compiler error.
The error is in code, which just came up with arm compiler and release profile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment