New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Semaphore wasn't released in easycellular release build. #7195

Merged
merged 1 commit into from Jun 15, 2018

Conversation

Projects
None yet
7 participants
@jarvte
Contributor

jarvte commented Jun 12, 2018

Description

Semaphore was released inside of MBED_ASSERT in EasyCellularConnection and so it was not released in release build.

@juhoeskeli please review.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@juhoeskeli

Looks good to me

@@ -42,7 +42,7 @@ bool EasyCellularConnection::cellular_status(int state, int next_state)

if (_target_state == state) {
tr_info("Target state reached: %s", _cellularConnectionFSM->get_state_string(_target_state));
MBED_ASSERT(_cellularSemaphore.release() == osOK);
(void)_cellularSemaphore.release();

This comment has been minimized.

@0xc0170

0xc0170 Jun 12, 2018

Member

Looks better, but we ignore the return value?

This comment has been minimized.

@jarvte

jarvte Jun 13, 2018

Contributor

Yes, we ignore it. There is nothing that can be done and no point doing if's just for printing semaphore release error which should never happen.

This comment has been minimized.

@cmonr

cmonr Jun 14, 2018

Contributor

@AnttiKauppila Quick thoughts on the above response?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 13, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 13, 2018

Build : SUCCESS

Build number : 2340
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7195/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Jun 14, 2018

@cmonr

cmonr approved these changes Jun 14, 2018

@cmonr cmonr added needs: review and removed ready for merge labels Jun 14, 2018

@adbridge adbridge merged commit 3e2e6a7 into ARMmbed:master Jun 15, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 921 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9107 cycles (-24 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@jarvte jarvte deleted the jarvte:fixing_easycellular_release_version branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment