New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPC54628: Update the ADC clock divider based on the input clock source #7201

Merged
merged 1 commit into from Jun 18, 2018

Conversation

Projects
None yet
6 participants
@mmahadevan108
Contributor

mmahadevan108 commented Jun 12, 2018

Description

  1. Problems were seen on the LPC54628 as the ADC clock source was too
    high
  2. Moved the pin configuration to set Analog mode to the end of the
    function

Tested this fix with the ci-test shield. The AnalogIn tests had problems running on the LPC54628, it would work on the LPC54608. This fix will make ADC works on both.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
LPC54628: Update the ADC clock divider based on the input clock source
1. Problems were seen on the LPC54628 as the ADC clock source was too
   high
2. Moved the pin configuration to set Analog mode to the end of the
   function

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Jun 12, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 12, 2018

@mmahadevan108 Are there test results that can be attached to this, since this is a fix for the ci-test shield?

@cmonr cmonr requested a review from maclobdell Jun 12, 2018

@cmonr cmonr added the needs: review label Jun 12, 2018

@cmonr

Just one question, but LGTM.

@@ -70,7 +80,7 @@ uint16_t analogin_read_u16(analogin_t *obj)
adcConvSeqConfigStruct.channelMask = (1U << channel);
adcConvSeqConfigStruct.triggerMask = 0U;
adcConvSeqConfigStruct.triggerPolarity = kADC_TriggerPolarityNegativeEdge;
adcConvSeqConfigStruct.triggerPolarity = kADC_TriggerPolarityPositiveEdge;

This comment has been minimized.

@cmonr

cmonr Jun 12, 2018

Contributor

Any partricular reason why this polarity flip was needed?

This comment has been minimized.

@mmahadevan108

mmahadevan108 Jun 12, 2018

Contributor

This is to match the values set inside the MCUXpresso SDK examples.

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Jun 12, 2018

The board does not have all the pins needed for the ci-test shield connected. As a result the ci-test shield's AnalogIn test does not pass. However with this fix the analog values are printed and the test no longer hangs.

@cmonr cmonr added needs: CI and removed needs: review labels Jun 13, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 13, 2018

Will hold off on starting CI until the test queue is a bit shorter. Appears to be stable again.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 13, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 13, 2018

Build : SUCCESS

Build number : 2337
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7201/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 14, 2018

@studavekar @OPpuolitaival Can you review the above failure. We noticed this timeout in the recent test runs.

@OPpuolitaival

This comment has been minimized.

Contributor

OPpuolitaival commented Jun 14, 2018

@studavekar need to check that. I don't have knowledge how that device is there

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 16, 2018

Going to rerun tests. Iirc, the issues have either been resolved and/or are no longer present.

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Jun 16, 2018

@cmonr cmonr merged commit f2b72b9 into ARMmbed:master Jun 18, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 921 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9274 cycles (+143 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@mmahadevan108 mmahadevan108 deleted the NXPmicro:Fix_ADC_LPC54628 branch Jul 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment