New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32: Fix data alignment issue in HASH function for F2, F7, L4 #7205

Merged
merged 1 commit into from Jun 20, 2018

Conversation

Projects
None yet
7 participants
@bcostm
Contributor

bcostm commented Jun 13, 2018

Description

This PR fixes an issue with data alignment in ST HAL hash write data function.

This is the same change has the one done in PR #7176 and it fixes Issue #7188.

@KariHaapalehto can you please review it and tell me which test(s) did you use to verify it on the STM32F4 ?

cc @ARMmbed/team-st-mcd for review also

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/team-st-mcd Jun 13, 2018

@KariHaapalehto

This comment has been minimized.

Contributor

KariHaapalehto commented Jun 13, 2018

Looks good to me +1.
ARM had a internal issue found in internal testing with mbed cloud client.
I ran internal testcase with GCC_ARM, ARM and IAR compilers with both release and debug profiles to verify fix

@0xc0170 0xc0170 requested a review from KariHaapalehto Jun 13, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 19, 2018

@ARMmbed/team-st-mcd Are y'all alright with the changes?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 19, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 19, 2018

Build : SUCCESS

Build number : 2387
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7205/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 20, 2018

Holding to wait for feedback from @ARMmbed/team-st-mcd, just in case.
Otherwise, this should be good to go.

@jeromecoutant

@bcostm is ST team :-)

@bcostm

This comment has been minimized.

Contributor

bcostm commented Jun 20, 2018

I agree with myself :) No seriously, we need to be coherent. This patch has been added for the F4 devices, so there is no reason to not add it for other STM32 devices... Otherwise we need to revert the F4 patch ...

@cmonr cmonr merged commit cc1e4f0 into ARMmbed:master Jun 20, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 921 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10905 cycles (+1774 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@bcostm bcostm deleted the bcostm:fix_hash_data_alignment branch Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment