New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Force small lib when compiling with uARM #7231

Merged
merged 1 commit into from Jun 18, 2018

Conversation

Projects
None yet
4 participants
@theotherjimmy
Contributor

theotherjimmy commented Jun 15, 2018

Description

PR #7197 blurred the lines between the ARM and uARM compilers. When making
those changes, I forgot to force -t uARM to compile with microlib. This PR
corrects the bad behavior that I introduced then

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 15, 2018

@adbridge @0xc0170 This fixes the bug i introduced into Mbed2 builds.

@cmonr

cmonr approved these changes Jun 15, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 15, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 16, 2018

Build : SUCCESS

Build number : 2363
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7231/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 18, 2018

/morph export-build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 18, 2018

#7197 (comment) - With this fix, now a target like nucleo f207 will be tested for mbed 2 with uARM (default toolchain). As we found out the last week. just want to make sure we do not have this again.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 18, 2018

@cmonr cmonr merged commit 476be14 into ARMmbed:master Jun 18, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 925 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9580 cycles (-804 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment