New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable XTS cipher mode by default when importing Mbed TLS #7243

Merged
merged 1 commit into from Jun 25, 2018

Conversation

Projects
None yet
7 participants
@k-stachowiak
Contributor

k-stachowiak commented Jun 18, 2018

Description

This PR updates the Mbed TLS import scripts so that the XTS cipher mode option is disabled by default.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[x] Feature
[ ] Breaking change

@cmonr cmonr requested a review from ARMmbed/mbed-os-connectivity Jun 18, 2018

@cmonr cmonr added the needs: review label Jun 18, 2018

@cmonr cmonr requested review from mazimkhan and hanno-arm and removed request for ARMmbed/mbed-os-connectivity Jun 18, 2018

@mazimkhan

LGTM

@sbutcher-arm

This comment has been minimized.

Contributor

sbutcher-arm commented Jun 22, 2018

@cmonr - This needs to be reviewed by someone on the @ARMmbed/mbed-os-crypto team. @hanno-arm and @mazimkhan are both on the TLS team.

cc: @Patater

@cmonr cmonr added needs: CI and removed needs: review labels Jun 22, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 22, 2018

@sbutcher-arm Thanks for the fyi.

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 22, 2018

Build : SUCCESS

Build number : 2435
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7243/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

cmonr approved these changes Jun 23, 2018

@cmonr cmonr added ready for merge and removed needs: CI labels Jun 23, 2018

@cmonr cmonr merged commit dd7555e into ARMmbed:master Jun 25, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 925 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9412 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment