New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default interface selection by using correct macro names. #7245

Merged
merged 2 commits into from Jun 19, 2018

Conversation

Projects
None yet
5 participants
@SeppoTakalo
Contributor

SeppoTakalo commented Jun 18, 2018

Description

Code was written using MBED_CONF_DEFAULT_* but the mbed_lib.json file
that created these values is prefixed with "nsapi" and therefore
final macros are MBED_CONF_NSAPI_DEFAULT_*

Also: when trying to use WIFI as the default, code did not compile. There was a small typo.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Fix default interface selection by using correct macro names.
Code was written using MBED_CONF_DEFAULT_* but the mbed_lib.json file
that created these values is prefixed with "nsapi" and therefore
final macros are MBED_CONF_NSAPI_DEFAULT_*
@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Jun 18, 2018

@kjbracey-arm Please review.

@cmonr cmonr requested review from kjbracey-arm and ARMmbed/mbed-os-ipcore Jun 18, 2018

@cmonr cmonr added the needs: review label Jun 18, 2018

Fix typo: WifiInterface -> WiFiInterface and add missing return.
Default WiFiInterface did not even build. And when it was fixed to build,
it was always returning NULL.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jun 19, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 19, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 19, 2018

Build : SUCCESS

Build number : 2381
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7245/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 19, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 19, 2018

@cmonr cmonr merged commit 2bb686f into ARMmbed:master Jun 19, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 925 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9049 cycles (-1081 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@SeppoTakalo SeppoTakalo deleted the SeppoTakalo:fix-default-interface branch Jun 19, 2018

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Jun 25, 2018

@0xc0170 this is missing 5.9.2 label. Should be added (or next patch release anyway)

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 25, 2018

Good catch 👍 Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment