New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide default WiFi interfaces for Ublox and Realtek #7259

Merged
merged 2 commits into from Jun 20, 2018

Conversation

Projects
None yet
5 participants
@SeppoTakalo
Contributor

SeppoTakalo commented Jun 19, 2018

Description

To allow application to choose default WiFi interface by calling WiFiInterface::get_default_instance() provide its implementation on these two targets.

Partially fixes:
#7257
#7246

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Jun 19, 2018

@cmonr cmonr requested review from kjbracey-arm and ARMmbed/team-realtek Jun 19, 2018

@cmonr cmonr added the needs: review label Jun 19, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 19, 2018

@SeppoTakalo Wasn't able to add @ARMmbed/team-ublox to the reviewers list for some reason.

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Jun 19, 2018

Its fine if Kevin approve, for Ublox and Realtek this is just for information.

@cmonr cmonr added needs: CI and removed needs: review labels Jun 19, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 19, 2018

/morph build

@@ -0,0 +1,7 @@
#include "RTWInterface.h"

This comment has been minimized.

@0xc0170

0xc0170 Jun 19, 2018

Member

license headers add to the new files

This comment has been minimized.

@SeppoTakalo

SeppoTakalo Jun 19, 2018

Contributor

Added

@SeppoTakalo SeppoTakalo force-pushed the SeppoTakalo:default_wifi branch from e14ef25 to bc18445 Jun 19, 2018

@SeppoTakalo SeppoTakalo force-pushed the SeppoTakalo:default_wifi branch from bc18445 to b4726cb Jun 19, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 19, 2018

Build : SUCCESS

Build number : 2386
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7259/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 19, 2018

Restarting build since commits after the last command moved the PR's Head sha.
/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 19, 2018

Build : SUCCESS

Build number : 2389
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7259/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Jun 20, 2018

@cmonr cmonr merged commit 567689c into ARMmbed:master Jun 20, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 927 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8960 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment