New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: fixed defect where SIM interface was closed too early #7275

Merged
merged 2 commits into from Jun 22, 2018

Conversation

Projects
None yet
6 participants
@jarvte
Contributor

jarvte commented Jun 20, 2018

Description

SIM interface was closed too early in CellularConnectionFSM.cpp causing a crash if APN lookup was enabled and apn configured to '0' in application json.
Crash happened EasyCellularConnection::connect(). Moved SIM interface closing a bit later.

Internal ref to defect: IOTCELL-1122

@AriParkkila please review

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@AriParkkila

Please push also to mbed-os-5.9

@0xc0170 0xc0170 requested a review from AnotherButler Jun 20, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 21, 2018

@jarvte @AriParkkila We're a bit confused. As is, this PR look like it will be going into 5.9.2.
Are y'all saying that this should instead be going to 5.10?

Copy edit CellularConnectionFSM.h
Copy edit for consistent tense and comma usage.

@AnotherButler AnotherButler dismissed stale reviews from 0xc0170 and AriParkkila via da6f2d9 Jun 21, 2018

@cmonr

cmonr approved these changes Jun 21, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 21, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 21, 2018

Build : SUCCESS

Build number : 2422
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7275/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 85f66ca into ARMmbed:master Jun 22, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 919 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8944 cycles (-745 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Jun 22, 2018

@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented Jun 25, 2018

@cmonr this fix should be good for all 5.9, 5.10 and master.

@jarvte jarvte deleted the jarvte:fix_sim_null_when_used branch Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment