New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPI initialization for NRF52 series #7280

Merged
merged 1 commit into from Jun 21, 2018

Conversation

Projects
None yet
4 participants
@marcuschangarm
Contributor

marcuschangarm commented Jun 20, 2018

Description

New changes to Mbed error reporting in 5.9 exposed bug in SPI driver where an instance was uninitialized twice which triggered an ASSERT.

This fix keeps track of which instance has been initialized and only calls uninit when it is safe.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Fix SPI initialization for NRF52 series
New changes to Mbed error reporting in 5.9 exposed bug in SPI
driver where an instance was uninitialized twice which triggered
an ASSERT.

This fix keeps track of which instance has been initialized and
only calls uninit when it is safe.
@cmonr

cmonr approved these changes Jun 20, 2018

@cmonr cmonr added the needs: CI label Jun 20, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 20, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 20, 2018

Build : SUCCESS

Build number : 2407
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7280/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 21, 2018

Fixes #7278

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 21, 2018

@cmonr cmonr merged commit b80490d into ARMmbed:master Jun 21, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 919 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9969 cycles (-44 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@marcuschangarm marcuschangarm deleted the marcuschangarm:fix-spi branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment