New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cellular information tests #7286

Merged
merged 3 commits into from Jun 27, 2018

Conversation

Projects
None yet
6 participants
@jarvte
Contributor

jarvte commented Jun 21, 2018

Description

  • added more unit tests for CellularInformation class
  • added greentea tests for CellularInformation class

Internal ref to defect: IOTCELL-945-947

@AriParkkila @AnttiKauppila please review

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-wan Jun 21, 2018

{
CellularInformation *info = cellular.get_device()->open_information(&cellular_serial);
char buf[100];

This comment has been minimized.

@AriParkkila

AriParkkila Jun 21, 2018

Contributor

Probably not good to take this from stack?

This comment has been minimized.

@jarvte

jarvte Jun 25, 2018

Contributor

Changed to heap

nsapi_error_t AT_CellularInformation::get_serial_number(char *buf, size_t buf_size, SerialNumberType type)
{
return 0;

This comment has been minimized.

@AriParkkila

AriParkkila Jun 21, 2018

Contributor

NSAPI_ERROR_OK makes more sense?

This comment has been minimized.

@jarvte

jarvte Jun 25, 2018

Contributor

fixed

@jarvte jarvte dismissed stale reviews from AnttiKauppila and AriParkkila via c6e0c0c Jun 25, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 25, 2018

/morph build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 25, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jun 25, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 25, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 25, 2018

Aborted one job (browser failed to render earlier CI run for me thus triggered 2x)

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 25, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 25, 2018

Build : SUCCESS

Build number : 2443
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7286/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 25, 2018

@jarvte A rebase is needed. As soon as it's ready, we'll restart CI.

@mbed-ci

This comment has been minimized.

@jarvte jarvte dismissed stale reviews from AnttiKauppila, 0xc0170, and AriParkkila via f64c84b Jun 26, 2018

@jarvte jarvte force-pushed the jarvte:add_cellular_information_tests branch from c6e0c0c to f64c84b Jun 26, 2018

@jarvte

This comment has been minimized.

Contributor

jarvte commented Jun 26, 2018

@cmonr rebase done.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Jun 26, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 26, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 26, 2018

Build : SUCCESS

Build number : 2445
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7286/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 27, 2018

Hi @jarvte. We recently found an issue with the way Astyle in Travis CI was being setup such that it was always failing PRs. The PR will need to be rebased to get the fix which is now in master (#7338).

Once this PR is rebased, we'll prioritize getting it back into CI as soon as possible.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 27, 2018

Ooor not...

sigh

At least we can merge this in.

@cmonr cmonr merged commit 8fab40a into ARMmbed:master Jun 27, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 928 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9628 cycles (+33 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Jun 27, 2018

@jarvte jarvte deleted the jarvte:add_cellular_information_tests branch Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment