New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBR: Fix issue with MBR init asserting on bad partition size #7299

Merged
merged 1 commit into from Jun 25, 2018

Conversation

Projects
None yet
6 participants
@geky
Member

geky commented Jun 21, 2018

Description

With the assert, applications were unable to check the corrupted MBR and correct it, so invalid data on a block device would prevent an application from recovering.

cc @marcuschangarm, @dlfryar, @ARMmbed/mbed-os-storage

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@cmonr

cmonr approved these changes Jun 21, 2018

👍

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 21, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 21, 2018

Build : SUCCESS

Build number : 2427
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7299/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 22, 2018

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-storage Jun 22, 2018

@geky

This comment has been minimized.

Member

geky commented Jun 25, 2018

Hey @dannybenor, @davidsaada, would one of you be able to review this pr. It's small but a part of the pr process.

@0xc0170 0xc0170 merged commit 8756183 into master Jun 25, 2018

15 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
travis-ci/astyle Passed, 919 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9996 cycles (+307 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
@geky

This comment has been minimized.

Member

geky commented Jun 25, 2018

@davidsaada Thanks!

@marcuschangarm

This comment has been minimized.

Contributor

marcuschangarm commented Jun 25, 2018

Thank you all! 🎉

@0xc0170 0xc0170 deleted the g-fix-mbr-invalid branch Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment