New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New target UNO_91H from RDA Microelectronics. #7309

Merged
merged 1 commit into from Nov 15, 2018

Conversation

@kyliuxing

kyliuxing commented Jun 25, 2018

Description

New target UNO_91H from RDA Microelectronics.

Pull request type

[ ] Fix
[ ] Refactor
[x] New target
[ ] Feature
[ ] Breaking change

greentea logs are attached below:
Greentea_report.zip

@kyliuxing

This comment has been minimized.

kyliuxing commented Jun 25, 2018

This PR inherit from #6508

@@ -538,6 +538,65 @@ class RTL8195ACode:
def binary_hook(t_self, resources, elf, binf):
from tools.targets.REALTEK_RTL8195AM import rtl8195a_elf2bin
rtl8195a_elf2bin(t_self, elf, binf)
class RDATargetCode:

This comment has been minimized.

@0xc0170

0xc0170 Jun 25, 2018

Member

@theotherjimmy Please review this addition

@@ -0,0 +1,174 @@
/* mbed Microcontroller Library
* Copyright (c) 2006-2013 ARM Limited

This comment has been minimized.

@0xc0170

0xc0170 Jun 25, 2018

Member

These files should have 2018 only year there

This comment has been minimized.

@kyliuxing

kyliuxing Jun 26, 2018

I have already corrected them.

#endif
// set to sleep
hal_sleep();

This comment has been minimized.

@0xc0170

0xc0170 Jun 25, 2018

Member

Does this pass the sleep test (hal - sleep tests) ?

This comment has been minimized.

@kyliuxing

kyliuxing Jun 25, 2018

yes, we have passed greentea test

This comment has been minimized.

@cmonr

cmonr Jun 28, 2018

Contributor

@kyliuxing Would you mind posting the results for all three compilers?

This comment has been minimized.

@kyliuxing

kyliuxing Jul 10, 2018

@cmonr I have added them.

; 8_byte_aligned(31 vect * 4 bytes) = 8_byte_aligned(0x7C) = 0x80
ER_IRAMVEC RDA_IRAM_BASE EMPTY 0x80 { ; Reserved for vectors
}
; IRAM Size: Total(128KB) - Vector(128B) - Stack(2KB)

This comment has been minimized.

@0xc0170

0xc0170 Jun 25, 2018

Member

@bulislaw Stack 1kB for new devices?

@0xc0170 0xc0170 added needs: work and removed needs: review labels Jun 25, 2018

@kyliuxing kyliuxing force-pushed the kyliuxing:master branch from e503765 to b567879 Jun 25, 2018

@kyliuxing kyliuxing changed the title from New target UNO_81C from RDA Microelectronics. to New target UNO_91H from RDA Microelectronics. Jun 25, 2018

@kyliuxing

This comment has been minimized.

kyliuxing commented Jun 25, 2018

Change target name from UNO_81C to UNO_91H

@theotherjimmy

Could you explain to me why you need the following files generated by your post-bulid script:

  • project.rcf
  • project_data.txt
  • project_dasm.txt

None of these are returned to the user by the online compiler.

@kyliuxing

This comment has been minimized.

kyliuxing commented Jun 27, 2018

@theotherjimmy Rcf file is used for design verification , data and dasm can help track crash issue.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 27, 2018

@kyliuxing We don't take post build scrits that "help track crash issues". Why is the RCF file needed by an arbitrary user?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 27, 2018

Further, Disassembly can be done by GDB, Uvision, IAR and many other IDEs without the use of any specialized infrastructure. Ditto for data section dumping (which is already part of the map file).

@kyliuxing kyliuxing force-pushed the kyliuxing:master branch from 8cb7c7e to 9a5fed3 Jun 28, 2018

@kyliuxing

This comment has been minimized.

kyliuxing commented Jun 28, 2018

@theotherjimmy I have removed them

Scripts removed

@@ -0,0 +1,27 @@
/* mbed Microcontroller Library - sbrkwrap
* Copyright (C) 2009-2018 ARM Limited. All rights reserved.

This comment has been minimized.

@0xc0170

0xc0170 Jun 29, 2018

Member

Can you edit this license to be as in other files

This comment has been minimized.

@kyliuxing
@@ -0,0 +1,5 @@
libhal files in the subfolders are generated with toolchains:
Arm Compiler 5 - version 5.06u1

This comment has been minimized.

@0xc0170

0xc0170 Jun 29, 2018

Member

👍

What license are these released with? Permissive Binary License?

This comment has been minimized.

@kyliuxing

kyliuxing Jul 10, 2018

@0xc0170 yes, I have added license.

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-tls Jun 29, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 29, 2018

@ARMmbed/mbed-os-tls Please review TRNG addition

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-hal Jun 29, 2018

@0xc0170 0xc0170 added the tracking label Jun 29, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jun 29, 2018

@kyliuxing Thanks! Now you're target will be trivial to get working in the online compiler.

@yanesca

This comment has been minimized.

Contributor

yanesca commented Jul 2, 2018

Can you please fix the reviewers? This needs to be reviewed by @mbed-os-crypto, not @mbed-os-tls.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 2, 2018

Can you please fix the reviewers? This needs to be reviewed by @mbed-os-crypto, not @mbed-os-tls.

Will do. Just to confirm for @ARMmbed/mbed-os-maintainers - TRNG belongs to the crypto team

@0xc0170 0xc0170 removed the request for review from ARMmbed/mbed-os-tls Jul 2, 2018

@0xc0170 0xc0170 requested a review from ashok-rao Nov 9, 2018

@cmonr cmonr added the needs: work label Nov 9, 2018

@kyliuxing

This comment has been minimized.

kyliuxing commented Nov 10, 2018

@0xc0170 Attachment Greentea_report.zip is already the latest GreenTea test results.Thanks!

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 10, 2018

@kyliuxing The PR still needs a rebase to resolve the current conflicts.

@kyliuxing kyliuxing force-pushed the kyliuxing:master branch from f0bec59 to 6270642 Nov 10, 2018

@kyliuxing

This comment has been minimized.

kyliuxing commented Nov 10, 2018

@cmonr done

@cmonr cmonr added needs: CI and removed needs: work labels Nov 12, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 12, 2018

Weird. Can't seem to dismiss @jamesbeyond's comment.

@jamesbeyond The tests results look good, aside from missing IAR, but not going to block this PR being able to start CI on that.

@kyliuxing Will start when able. We're looking at a couple of things internally.

@jamesbeyond

This comment has been minimized.

Contributor

jamesbeyond commented Nov 12, 2018

Hi @kyliuxing @cmonr , test results Look good to me. Thanks

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 12, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 12, 2018

Build : SUCCESS

Build number : 3602
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7309/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 14, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 14, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 14, 2018

Test failure is still unrelated to PR...
Will restart when able.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 15, 2018

Note: This PR is now a part of a rollup PR (#8753).

In order to expedite remaining CI testing, this PR has been bundled into the above rollup PR.

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 15, 2018

Please ignore. I derped.

@cmonr cmonr merged commit 6270642 into ARMmbed:master Nov 15, 2018

17 of 18 checks passed

ci-morph-test test completed
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 49 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10267 cycles (+29 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment