New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoRaWAN: Correcting doxygen #7348

Merged
merged 3 commits into from Jul 2, 2018

Conversation

Projects
None yet
5 participants
@hasnainvirk
Contributor

hasnainvirk commented Jun 27, 2018

Description

Use of MSG_FLAGS was updated in previous PRs but the doc was not updated
accordingly.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Target

Next patch release

Correcting doxygen
Use of MSG_FLAGS was updated in previous PRs but the doc was not updated
accordingly.
@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Jun 27, 2018

@0xc0170 @cmonr Please review.

@hasnainvirk hasnainvirk changed the title from Correcting doxygen to LoRaWAN: Correcting doxygen Jun 27, 2018

@0xc0170 0xc0170 requested a review from AnotherButler Jun 27, 2018

@adbridge adbridge requested a review from ARMmbed/mbed-docs Jun 27, 2018

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Jun 29, 2018

@0xc0170 CI needed here.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 29, 2018

We will run as soon as docs team review (be aware that RC are going to be scheduled also soon).

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Jun 29, 2018

@0xc0170 It's a minor change. It should have been made with the corresponding PR, my mistake.
@peknis01 Can you please review to expedite the process ?

Copy edit LoRaWANinterface.h
Copy edit for precise language and comma use.
Copy edit LoRaWANBase.h
Copy edit for precise language and comma use.
@cmonr

cmonr approved these changes Jun 30, 2018

@cmonr cmonr requested a review from peknis01 Jun 30, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 30, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 30, 2018

Build : SUCCESS

Build number : 2484
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7348/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Jun 30, 2018

@0xc0170 0xc0170 merged commit 3ee8f32 into ARMmbed:master Jul 2, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 913 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10200 cycles (+1262 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment