New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: EasyCellularConnection::connect doesn't have any check that "CellularConnectionFSM" object is created or not #7359

Merged
merged 1 commit into from Jun 30, 2018

Conversation

Projects
None yet
7 participants
@mudassar-ublox
Contributor

mudassar-ublox commented Jun 28, 2018

Description

EasyCellularConnection::connect doesn't have any check that "CellularConnectionFSM" object is created or not resulting into Hard Fault Handler. Instead of calling "_cellularConnectionFSM->set_sim_pin" method call "EasyCellularConnection::set_sim_pin" method. Which will create object of "CellularConnectionFSM" first, if not created already, and then set sim pin.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-wan Jun 28, 2018

@jarvte

jarvte approved these changes Jun 28, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jun 28, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 28, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 28, 2018

Build : SUCCESS

Build number : 2468
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7359/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 28, 2018

Pipe closed.

/morph export-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 28, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 29, 2018

/morph export-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 29, 2018

/morph mbed2-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 29, 2018

/morph export-build

1 similar comment
@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 29, 2018

/morph export-build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 29, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 29, 2018

CI failure, restarting

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 58b725b into ARMmbed:master Jun 30, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 929 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10258 cycles (+187 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Jun 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment