New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 : get serial RX/TX active state #7361

Merged
merged 1 commit into from Jun 29, 2018

Conversation

Projects
None yet
6 participants
@jeromecoutant
Contributor

jeromecoutant commented Jun 28, 2018

Description

We don't report any real issue yet, patch is proposed thanks to some code review.

In serial_tx_active and serial_rx_active functions,
we check the internal state value with

HAL_UART_STATE_BUSY_TX = 0x21U,
HAL_UART_STATE_BUSY_RX = 0x22U,

It seems that value can also be :
HAL_UART_STATE_BUSY_TX_RX = 0x23U,

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/team-st-mcd Jun 28, 2018

@0xc0170

commit msg is STM32 serial RX/TX active patch

Should the second paragraph contain the info from description? It's small change but to me that description made it clear what is changing here

@jeromecoutant jeromecoutant force-pushed the jeromecoutant:PR_SERIAL branch from 2bd5037 to 4f9dc33 Jun 28, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 28, 2018

/morph build

@0xc0170 0xc0170 added the needs: CI label Jun 28, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 28, 2018

Build : SUCCESS

Build number : 2470
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7361/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr cmonr added needs: work and removed needs: CI labels Jun 28, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 28, 2018

@jeromecoutant Looks like the astyle PR has caused this to need a rebase.

STM32 serial RX/TX active patch
In serial_tx_active and serial_rx_active functions,
we check the internal state value with

HAL_UART_STATE_BUSY_TX = 0x21U,
HAL_UART_STATE_BUSY_RX = 0x22U,

It seems that value can also be :
HAL_UART_STATE_BUSY_TX_RX = 0x23U,

@jeromecoutant jeromecoutant dismissed stale reviews from bcostm and 0xc0170 via 3721ac4 Jun 28, 2018

@jeromecoutant jeromecoutant force-pushed the jeromecoutant:PR_SERIAL branch from 4f9dc33 to 3721ac4 Jun 28, 2018

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Jun 28, 2018

Rebase done

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 28, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 28, 2018

Build : SUCCESS

Build number : 2473
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7361/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 28, 2018

#7361 (comment) This was from the first build. Ignore.

@mbed-ci

This comment has been minimized.

@cmonr

cmonr approved these changes Jun 29, 2018

@cmonr cmonr merged commit 615d29e into ARMmbed:master Jun 29, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 913 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10245 cycles (+1121 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_SERIAL branch Jun 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment